From: Gustavo Zacarias <gustavo@zacarias.com.ar>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] nommu/flat: build packages with the correct FLAGS
Date: Wed, 11 Sep 2013 10:41:55 -0300 [thread overview]
Message-ID: <52307323.6050400@zacarias.com.ar> (raw)
In-Reply-To: <20130911154013.1dee2f28@skate>
On 09/11/2013 10:40 AM, Thomas Petazzoni wrote:
> Dear Gustavo Zacarias,
>
> On Wed, 11 Sep 2013 09:53:44 -0300, Gustavo Zacarias wrote:
>
>> ifeq ($(BR2_BINFMT_FLAT),y)
>> +TARGET_CFLAGS += $(if $($(PKG)_FLAT_STACKSIZE),-Wl$(comma)-elf2flt=-s$($(PKG)_FLAT_STACKSIZE),\
>> + -Wl$(comma)-elf2flt)
>
> Nitpicking, can't this be written:
>
> TARGET_CFLAGS += -Wl$(comma)-elf2flt$(if $($(PKG)_FLAT_STACKSIZE),=-s$($(PKG)_FLAT_STACKSIZE))
>
> not sure if it's more readable though.
Yes very likely, but i went for readable :)
If the FLAT support is extended there may be other options appended
there and separate clauses will be likely/better to avoid duplication
and general uglyness.
Regards.
next prev parent reply other threads:[~2013-09-11 13:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-11 12:53 [Buildroot] [PATCH] nommu/flat: build packages with the correct FLAGS Gustavo Zacarias
2013-09-11 13:40 ` Thomas Petazzoni
2013-09-11 13:41 ` Gustavo Zacarias [this message]
2013-09-12 22:12 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52307323.6050400@zacarias.com.ar \
--to=gustavo@zacarias.com.ar \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox