From: Thierry Bultel <thierry.bultel@wanadoo.fr>
To: buildroot@busybox.net
Subject: [Buildroot] Broken generation of locales
Date: Thu, 19 Sep 2013 17:28:07 +0200 [thread overview]
Message-ID: <523B1807.1070102@wanadoo.fr> (raw)
In-Reply-To: <20130919170406.0e04a348@skate>
Hi Thomas,
This does not exactly revert the named commit, that
added 's' for both inputfile and charmap.
I pretend that the 's' option is mandatory for charmap only,
else inputfile is always empty:
inputfile:
thierry at thierry-desktop:~$ echo fr_FR | cut -f1 -d '.'
fr_FR
thierry at thierry-desktop:~$ echo fr_FR | cut -f1 -d '.' -s
thierry at thierry-desktop:~$
charmap:
thierry at thierry-desktop:~$ echo fr_FR.utf8 | cut -f2 -d '.'
utf8
thierry at thierry-desktop:~$ echo fr_FR.utf8 | cut -f2 -d '.' -s
utf8
thierry at thierry-desktop:~$ cut --version
cut (GNU coreutils) 7.4
Cheers
Thierry
Le 19/09/2013 17:04, Thomas Petazzoni a ?crit :
> Dear Thierry Bultel,
>
> On Thu, 19 Sep 2013 08:09:12 +0200, Thierry Bultel wrote:
>
>> When setting BR2_GENERATE_LOCALE, for instance like that:
>> BR2_GENERATE_LOCALE="fr_FR en_US es_ES es_ES.ISO-8859-1 hu_HU"
>>
>> nothing is generated.
>>
>> next patch fixes that issue:
>>
>> diff --git a/Makefile b/Makefile
>> index 7997e3b..98afd7e 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -543,8 +543,8 @@ ifneq ($(GENERATE_LOCALE),)
>> target-generatelocales: host-localedef
>> $(Q)mkdir -p $(TARGET_DIR)/usr/lib/locale/
>> $(Q)for locale in $(GENERATE_LOCALE) ; do \
>> - inputfile=`echo $${locale} | cut -f1 -d'.' -s` ; \
>> - charmap=`echo $${locale} | cut -f2 -d'.' -s` ; \
>> + inputfile=`echo $${locale} | cut -f1 -d'.'` ; \
>> + charmap=`echo $${locale} | cut -s -f2 -d'.'` ; \
>> if test -z "$${charmap}" ; then \
>> charmap="UTF-8" ; \
>> fi ; \
> This exactly reverts commit 8e2696eab6a781727c09408528678d4d29edd7a3
> which was merged in August. I've added Arnout in Cc so that you can
> discuss the issue together and decide who wins :-)
>
> Thanks,
>
> Thomas
next prev parent reply other threads:[~2013-09-19 15:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-19 6:09 [Buildroot] Broken generation of locales Thierry Bultel
2013-09-19 15:04 ` Thomas Petazzoni
2013-09-19 15:28 ` Thierry Bultel [this message]
2013-09-19 19:12 ` Arnout Vandecappelle
2013-09-19 19:30 ` Thomas Petazzoni
2013-09-19 20:32 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=523B1807.1070102@wanadoo.fr \
--to=thierry.bultel@wanadoo.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox