From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/5] qt5: bump to 5.1.1
Date: Thu, 19 Sep 2013 19:41:45 +0200 [thread overview]
Message-ID: <523B3759.1000901@mind.be> (raw)
In-Reply-To: <1379568660.27759.4.camel@viko>
On 19/09/13 07:31, Fatih A??c? wrote:
> On Thu, 2013-09-19 at 06:24 +0200, Thomas Petazzoni wrote:
>>>>> -@@ -0,0 +1,43 @@
>>>>> +@@ -0,0 +1,44 @@
>>>>>
>>>>> +MAKEFILE_GENERATOR = UNIX
>>>>>
>>>>> -+CONFIG += incremental gdb_dwarf_index
>>>>> ++CONFIG += incremental gdb_dwarf_index
>>>>
>>>> Is this change needed? Seems like white space change only, no?
>>>
>>> I checked the mkspec files in old and new versions of upstream.
>> Upstream's
>>> files have this change. So I changed our mkspec file to reduce diff
>> output.
>>> I think, this will help checking again in new versions. Yes, it is
>> only
>>> a white space change and not needed.
>>
>> It's a bit early, so maybe my brain is not yet up and running, but if
>> the upstream has changed this, and we don't care about whether there's
>> a space or not, why does our patch contains something to change this?
>
> It is just a cosmetic change not to see the difference when comparing
> files :)
>
> If the rule is not to touch anywhere unrelated to the version change, I
> can revert that part.
I think it's a good idea to keep it. The closer that our mkspecs stays
to one of the upstream examples, the better.
Perhaps we could try upstreaming our mkspecs? Does that make sense?
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
next prev parent reply other threads:[~2013-09-19 17:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-18 18:18 [Buildroot] [PATCH 1/5] qt5: bump to 5.1.1 Fatih Aşıcı
2013-09-19 4:24 ` Thomas Petazzoni
2013-09-19 5:31 ` Fatih Aşıcı
2013-09-19 17:41 ` Arnout Vandecappelle [this message]
2013-09-19 18:55 ` Thomas Petazzoni
2013-09-21 7:43 ` Peter Korsgaard
2013-09-21 18:38 ` Fatih Aşıcı
2013-09-22 7:39 ` Thomas Petazzoni
-- strict thread matches above, loose matches on Subject: below --
2013-09-18 6:28 [Buildroot] [PATCH 0/5] Bump Qt5 to version 5.1.1 Fatih Aşıcı
2013-09-18 6:28 ` [Buildroot] [PATCH 1/5] qt5: bump to 5.1.1 Fatih Aşıcı
2013-09-18 17:04 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=523B3759.1000901@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox