From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3 of 4] manual generation: check dependencies first
Date: Thu, 19 Sep 2013 21:30:44 +0200 [thread overview]
Message-ID: <523B50E4.6020906@mind.be> (raw)
In-Reply-To: <246bed054da59d6508dc.1379587635@argentina>
On 19/09/13 12:47, Thomas De Schampheleire wrote:
> To generate the manual, you need asciidoc and w3m. If these are not present,
> pretty cryptic error messages are given.
> This patch adds a simple check for these dependencies, before attempting to
> build the manual.
>
> Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
>
> ---
> docs/manual/manual.mk | 11 +++++++++++
> 1 files changed, 11 insertions(+), 0 deletions(-)
>
> diff --git a/docs/manual/manual.mk b/docs/manual/manual.mk
> --- a/docs/manual/manual.mk
> +++ b/docs/manual/manual.mk
> @@ -3,6 +3,16 @@ manual-update-lists:
> $(Q)BR2_DEFCONFIG="" TOPDIR=$(TOPDIR) O=$(O)/docs/manual/.build \
> $(TOPDIR)/support/scripts/gen-manual-lists.py
>
> +manual-check-dependencies:
> + $(Q)if [ -z "`which a2x 2>/dev/null`" ]; then \
> + echo "You need asciidoc on your host to generate the manual"; \
> + false; \
I don't think this works. I think you need "exit 1;".
Regards,
Arnout
> + fi
> + $(Q)if [ -z "`which w3m 2>/dev/null`" ]; then \
> + echo "You need w3m on your host to generate the manual"; \
> + false; \
> + fi
> +
> ################################################################################
> # GENDOC -- generates the make targets needed to build a specific type of
> # asciidoc documentation.
> @@ -24,6 +34,7 @@ define GENDOC_INNER
>
> $$(O)/docs/$(1)/$(1).$(4): docs/$(1)/$(1).txt \
> $$($(call UPPERCASE,$(1))_SOURCES) \
> + manual-check-dependencies \
> manual-update-lists
> $(Q)$(call MESSAGE,"Generating $(5) $(1)...")
> $(Q)mkdir -p $$(@D)/.build
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
next prev parent reply other threads:[~2013-09-19 19:30 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-19 10:47 [Buildroot] [PATCH 0 of 4] manual generation: misc changes Thomas De Schampheleire
2013-09-19 10:47 ` [Buildroot] [PATCH 1 of 4] manual generation: change capitalization of messages Thomas De Schampheleire
2013-09-19 15:37 ` Thomas Petazzoni
2013-09-20 13:17 ` Peter Korsgaard
2013-09-19 10:47 ` [Buildroot] [PATCH 2 of 4] manual generation: update help Thomas De Schampheleire
2013-09-19 15:37 ` Thomas Petazzoni
2013-09-20 13:17 ` Peter Korsgaard
2013-09-19 10:47 ` [Buildroot] [PATCH 3 of 4] manual generation: check dependencies first Thomas De Schampheleire
2013-09-19 11:43 ` Samuel Martin
2013-09-19 13:30 ` Thomas De Schampheleire
2013-09-19 14:28 ` Ryan Barnett
2013-09-19 15:08 ` Thomas De Schampheleire
2013-09-19 15:20 ` Ryan Barnett
2013-09-19 15:39 ` Thomas Petazzoni
2013-09-19 16:27 ` Thomas De Schampheleire
2013-09-19 18:57 ` Thomas Petazzoni
2013-09-19 19:29 ` Arnout Vandecappelle
2013-09-19 19:30 ` Arnout Vandecappelle [this message]
2013-09-20 18:23 ` Thomas De Schampheleire
2013-09-19 10:47 ` [Buildroot] [PATCH 4 of 4] manual generation: rename manual-txt into manual-text Thomas De Schampheleire
2013-09-19 15:40 ` Thomas Petazzoni
2013-09-19 15:49 ` Thomas De Schampheleire
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=523B50E4.6020906@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox