From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jerzy Grzegorek <jerzy.grzegorek@trzebnica.net>
Date: Wed, 02 Oct 2013 11:48:19 +0200
Subject: [Buildroot] [PATCH 1/1] package: fix github download URL
In-Reply-To: <20131001205849.1cdcee4f@skate>
References: <1380195788-32432-1-git-send-email-jerzy.grzegorek@trzebnica.net>	<524AAA6D.8000103@mind.be>	<524ABEFA.8080804@trzebnica.net>
 <20131001205849.1cdcee4f@skate>
Message-ID: <524BEBE3.2020004@trzebnica.net>
List-Id: <buildroot.busybox.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: buildroot@busybox.net


Arnout, Thomas,

Thanks for your comments.


> Dear Jerzy Grzegorek,
>
> On Tue, 01 Oct 2013 14:24:26 +0200, Jerzy Grzegorek wrote:
>
>>> On 09/26/13 13:43, Jerzy Grzegorek wrote:
>>>> diff --git a/package/cpuload/cpuload.mk b/package/cpuload/cpuload.mk
>>>> index e0b8ccf..d00c3a4 100644
>>>> --- a/package/cpuload/cpuload.mk
>>>> +++ b/package/cpuload/cpuload.mk
>>>> @@ -4,8 +4,8 @@
>>>>    #
>>>> ################################################################################
>>>>
>>>> -CPULOAD_VERSION = v0.3
>>>> -CPULOAD_SITE
>>>> =http://github.com/kelvincheung/cpuload/tarball/$(CPULOAD_VERSION)
>>>> +CPULOAD_SITE
>>>> =https://github.com/kelvincheung/cpuload/tarball/v$(CPULOAD_VERSION)
>>>>    CPULOAD_LICENSE = GPLv2
>>>   Not that it's a big deal to me, but I don't agree with the concept of
>>> this change. The meaning of this URL is that you export a certain tag
>>> from a git repository. It is conceptually not the same as a release
>>> tarball that a project creates. Therefore, I think the VERSION should
>>> be exactly the same as the tag name, so that it stays as close as
>>> possible as what we would have if we used the git site method.
>>>
>> Take into account that if tag has prefix, BR generates tarball with
>> weird name.
>> For instance for libcec:
>> tag: libcec-2.1.1
>> LIBCEC_VERSION = libcec-2.1.1
>> LIBCEC_SITE =
>> https://github.com/Pulse-Eight/libcec/tarball/$(LIBCEC_VERSION)
>> tarball name downloaded by BR: libcec-libcec-2.1.1.tar.gz
>>
>> but when
>> LIBCEC_VERSION = 2.1.1
>> LIBCEC_SITE =
>> https://github.com/Pulse-Eight/libcec/tarball/libcec-$(LIBCEC_VERSION)
>> the tarball name generated by github matches the one from BR:
>> libcec-2.1.1.tar.gz
> I tend to agree with Arnout. We don't care if tarballs have weird
> names, upstream projects should simply learn to name their tags
> properly. Having <pkg>_VERSION match the Git tag name seems more
> important to me than having nice tarball names.

Ok, then I'll send a patch to cleanup
civetweb, liblog4c-localtime, mongrel2 and sqlcipher .


Regards,
Jerzy


> Best regards,
>
> Thomas