Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v7 3/6] package/Makefile.in: don't force jobs when BR2_JLEVEL is empty
Date: Thu, 03 Oct 2013 18:54:15 +0200	[thread overview]
Message-ID: <524DA137.304@mind.be> (raw)
In-Reply-To: <1380802245-16978-4-git-send-email-fabio.porcedda@gmail.com>

On 10/03/13 14:10, Fabio Porcedda wrote:
> When the "BR2_JLEVEL" variable is empty use "make" without
> the "-j" option, because to be able to use top-level parallel
> make we must don't force the number of jobs in sub-make.
>
> Example:
> 	make BR2_JLEVEL= -j8
>
> Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
> Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

  Peter, can we get this committed?

  Regards,
  Arnout

> ---
>   package/Makefile.in | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/Makefile.in b/package/Makefile.in
> index 170ad78..d406901 100644
> --- a/package/Makefile.in
> +++ b/package/Makefile.in
> @@ -18,7 +18,7 @@ PARALLEL_JOBS:=$(BR2_JLEVEL)
>   endif
>
>   MAKE1:=$(HOSTMAKE) -j1
> -MAKE:=$(HOSTMAKE) -j$(PARALLEL_JOBS)
> +MAKE:=$(HOSTMAKE) $(if $(PARALLEL_JOBS),-j$(PARALLEL_JOBS))
>
>   # Compute GNU_TARGET_NAME
>   GNU_TARGET_NAME=$(ARCH)-buildroot-$(TARGET_OS)-$(LIBC)$(ABI)
>


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

  reply	other threads:[~2013-10-03 16:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-03 12:10 [Buildroot] [PATCH v7 0/6] Fixes for top-level parallel make Fabio Porcedda
2013-10-03 12:10 ` [Buildroot] [PATCH v7 1/6] package: add toolchain dependency to inner-generic-package Fabio Porcedda
2013-10-03 12:10 ` [Buildroot] [PATCH v7 2/6] pkg-generic: fix rules for top-level parallel make Fabio Porcedda
2013-10-03 12:10 ` [Buildroot] [PATCH v7 3/6] package/Makefile.in: don't force jobs when BR2_JLEVEL is empty Fabio Porcedda
2013-10-03 16:54   ` Arnout Vandecappelle [this message]
2013-10-04 13:08     ` Peter Korsgaard
2013-10-03 12:10 ` [Buildroot] [PATCH v7 4/6] pkg-generic: enable jobserver for recursive make Fabio Porcedda
2013-10-03 12:10 ` [Buildroot] [PATCH v7 5/6] Makefile: fix rules for top-level parallel make Fabio Porcedda
2013-10-03 12:10 ` [Buildroot] [PATCH v7 6/6] Makefile: enable " Fabio Porcedda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=524DA137.304@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox