From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] pkg-infra: log current message
Date: Tue, 08 Oct 2013 18:47:37 +0200 [thread overview]
Message-ID: <52543729.2010809@mind.be> (raw)
In-Reply-To: <20131007191905.7715dd69@skate>
On 10/07/13 19:19, Thomas Petazzoni wrote:
> Dear Yann E. MORIN,
>
> On Mon, 7 Oct 2013 18:59:56 +0200, Yann E. MORIN wrote:
>
>>> It would then be the responsibility of the user to provide such a
>>> script. We could provide a simple script that just do this logging as an
>>> example.
>>
>> I have another interesting idea about such a script: detect whether a
>> package overwrites or otherwise modifies a file already existing in
>> staging/ and/or target/ to assess for the sanity of the packaging.
>
> I believe there are cases where we are doing this today, and where it
> is valid. Think for example the full-blown versions of some commands
> that overwrite the symbolic link installed by Busybox.
>
>> We could also add another sanity-check to look at build issues (eg.
>> build-path in RPATH, build-path in scripts...).
>
> Right! However, I don't see why those checks should be in some external
> scripts that the user should install. I believe those checks should be
> part of the Buildroot core, possibly with a Config.in option to decide
> whether a check failure should result to a global build failure or just
> a warning (default value would be a warning, a global build failure
> could be used in the autobuilders, for example).
I agree with that. Any check or whatever that makes life easier for a
contributor should be part of the mainline.
That said, it still makes sense to give the possibility to add custom
pre/post hooks. And autobuilder-specific things that are _not_ relevant
to the generic contributor would fit there.
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
next prev parent reply other threads:[~2013-10-08 16:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-06 11:19 [Buildroot] [PATCH] pkg-infra: log current message Yann E. MORIN
2013-10-06 14:31 ` Thomas Petazzoni
2013-10-07 10:09 ` Jérôme Pouiller
2013-10-07 12:07 ` Thomas Petazzoni
2013-10-07 16:48 ` Yann E. MORIN
2013-10-07 16:59 ` Yann E. MORIN
2013-10-07 17:19 ` Thomas Petazzoni
2013-10-08 16:47 ` Arnout Vandecappelle [this message]
2013-10-07 20:53 ` Jérôme Pouiller
2013-10-07 19:46 ` Jérôme Pouiller
2013-10-08 16:53 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52543729.2010809@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox