Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] Buildroot patchwork: decision on the 10 oldest patches, week 1
Date: Sun, 13 Oct 2013 23:18:20 +0200	[thread overview]
Message-ID: <525B0E1C.1070908@mind.be> (raw)
In-Reply-To: <CAAXf6LVkmwRhw2TGyGtjts1ePNkCj=5pGgTk00GWJFaECq-k7Q@mail.gmail.com>

On 11/10/13 10:11, Thomas De Schampheleire wrote:
>> 10 grub: add host support
>> >    http://patchwork.ozlabs.org/patch/177705/
>> >    rbraun at sceen.net
> Arnout: you gave a positive reply on this patch, is it still valid.
> Can we merge it as-is, or does the patch need more work? The patch
> still applies cleanly and builds fine, however I found the output is
> much larger than I expected (although this may be me not understanding
> exactly). Is it normal to have grub stages exceeding 100MB ?
>
> $ ls -lh /home/tdescham/repo/contrib/buildroot-review/output/host/boot/grub
> total 1,7G
> -rwxr-xr-x 1 tdescham tdescham 129M okt 11 10:04 e2fs_stage1_5
> -rwxr-xr-x 1 tdescham tdescham 129M okt 11 10:04 fat_stage1_5
> -rwxr-xr-x 1 tdescham tdescham 129M okt 11 10:05 ffs_stage1_5
> -rwxr-xr-x 1 tdescham tdescham 129M okt 11 10:05 iso9660_stage1_5
> -rwxr-xr-x 1 tdescham tdescham 129M okt 11 10:05 jfs_stage1_5
> -rwxr-xr-x 1 tdescham tdescham 129M okt 11 10:05 minix_stage1_5
> -rwxr-xr-x 1 tdescham tdescham 129M okt 11 10:05 reiserfs_stage1_5
> -rwxr-xr-x 1 tdescham tdescham 129M okt 11 10:04 stage1
> -rw-r--r-- 1 tdescham tdescham 257M okt 11 10:05 stage2
> -rwxr-xr-x 1 tdescham tdescham 129M okt 11 10:05 ufs2_stage1_5
> -rwxr-xr-x 1 tdescham tdescham 129M okt 11 10:05 vstafs_stage1_5
> -rwxr-xr-x 1 tdescham tdescham 129M okt 11 10:05 xfs_stage1_5

  That indeed doesn't look good.

  For some reason, the ELF objects have two load addresses: 0x00002000 
and 0x080480d4. Therefore objdump generates a full 128MB dump filled with 
zeroes. It possibly has to do with recent binutils - this grub 0.97 is 
already more than 8 years old.

  I wouldn't spend too much effort on grub anymore, and instead focus on 
grub2.


  Regards,
  Arnout


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

  reply	other threads:[~2013-10-13 21:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-06 14:42 [Buildroot] Buildroot patchwork: decision on the 10 oldest patches, week 1 Thomas Petazzoni
2013-10-08 15:17 ` Ludovic Desroches
2013-10-09  9:34   ` [Buildroot] [PATCH] New: add lava-test package ludovic.desroches at atmel.com
2013-10-09 11:55     ` Thomas Petazzoni
2013-10-09 14:42       ` Ludovic Desroches
2013-10-11  8:11 ` [Buildroot] Buildroot patchwork: decision on the 10 oldest patches, week 1 Thomas De Schampheleire
2013-10-13 21:18   ` Arnout Vandecappelle [this message]
2013-11-01  8:07   ` Thomas De Schampheleire
2013-11-01  9:57     ` Gustavo Zacarias

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=525B0E1C.1070908@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox