From: Markos Chandras <Markos.Chandras@imgtec.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] ext-toolchain: MIPS: Select correct endianness for the target
Date: Mon, 14 Oct 2013 11:21:53 +0100 [thread overview]
Message-ID: <525BC5C1.3050705@imgtec.com> (raw)
In-Reply-To: <20131014120543.267c23a7@skate>
Hi Thomas,
On 10/14/13 11:05, Thomas Petazzoni wrote:
> Dear Markos Chandras,
>
> On Mon, 14 Oct 2013 10:52:25 +0100, Markos Chandras wrote:
>> +ifeq ($(BR2_mipsel)$(BR2_mips64el),y)
>> +ifeq ($(BR2_ENDIAN),"LITTLE")
>
> If we're on mipsel or mips64el, we're always little endian, right? So
> maybe the test on BR2_ENDIAN isn't that useful? :-)
Oh right that makes sense...
>
>> +TOOLCHAIN_EXTERNAL_WRAPPER_ARGS += -DBR_MIPS_TARGET_LITTLE_ENDIAN
>> +TOOLCHAIN_EXTERNAL_CFLAGS += -EL
>> +endif
>> +endif
>
> Should we do it for -EB as well? Or do we consider because the Sourcery
> toolchain defaults to big endian we don't need to explicit -EB ?
It's not necessary because the default is for big endian. But if you
prefer to do that for the sake of consinstency I am fine with it :)
Peter can you fix this patch before you commit it or should I send a v2?
--
markos
next prev parent reply other threads:[~2013-10-14 10:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-14 9:52 [Buildroot] [PATCH] ext-toolchain: MIPS: Select correct endianness for the target Markos Chandras
2013-10-14 10:05 ` Thomas Petazzoni
2013-10-14 10:21 ` Markos Chandras [this message]
2013-10-14 10:26 ` Thomas Petazzoni
2013-10-16 9:40 ` Markos Chandras
2013-10-30 17:52 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=525BC5C1.3050705@imgtec.com \
--to=markos.chandras@imgtec.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox