From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v8 RESEND 1/8] package: add base dependency to every package
Date: Fri, 25 Oct 2013 10:12:42 +0200 [thread overview]
Message-ID: <526A27FA.10602@mind.be> (raw)
In-Reply-To: <CAHkwnC9s0ZqVoE-5pZFwxb4adFw0hD3+SxrF4ri7jStbxypjTA@mail.gmail.com>
On 25/10/13 10:07, Fabio Porcedda wrote:
> On Thu, Oct 24, 2013 at 12:37 PM, Arnout Vandecappelle<arnout@mind.be> wrote:
>> >On 24/10/13 09:41, Fabio Porcedda wrote:
>>> >>
[snip]
>>> >>I've found a work around:
>>> >>
>>> >>$$($(2)_TARGET_SOURCE) $$($(2)_TARGET_RSYNC): | dirs prepare
>>> >>
>>> >># to prevent circular dependency
>>> >>ifneq ($(1),$(DEPENDENCIES_HOST_PREREQ))
>>> >>$$($(2)_TARGET_SOURCE) $$($(2)_TARGET_RSYNC): | dependencies
>>> >>endif
>>> >>
>>> >>What do you think about that?
>> >
>> >
>> > Looks good except that it's incorrect:-) If HOST_PREREQ contains both
>> >ccache and sstrip (not to mention tar or xz), the condition won't match. You
>> >can try something like:
>> >
>> >ifeq ($(filter $(1),$(DEPENDENCIES_HOST_PREREQ)),)
> Ok good, I've updated the patch according.
>
Have you tested it with various combinations of dependencies?
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
next prev parent reply other threads:[~2013-10-25 8:12 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-18 9:34 [Buildroot] [PATCH v8 RESEND 0/8] Add support for top-level parallel make Fabio Porcedda
2013-10-18 9:34 ` [Buildroot] [PATCH v8 RESEND 1/8] package: add base dependency to every package Fabio Porcedda
2013-10-23 21:12 ` Arnout Vandecappelle
2013-10-24 7:41 ` Fabio Porcedda
2013-10-24 8:22 ` Thomas De Schampheleire
2013-10-25 8:09 ` Fabio Porcedda
2013-10-24 10:37 ` Arnout Vandecappelle
2013-10-25 8:07 ` Fabio Porcedda
2013-10-25 8:12 ` Arnout Vandecappelle [this message]
2013-10-25 8:45 ` Fabio Porcedda
2013-10-29 8:36 ` Fabio Porcedda
2013-10-29 9:35 ` Thomas De Schampheleire
2013-10-29 11:06 ` Fabio Porcedda
2013-10-18 9:34 ` [Buildroot] [PATCH v8 RESEND 2/8] package: add toolchain dependency to every target package Fabio Porcedda
2013-10-23 21:53 ` Arnout Vandecappelle
2013-10-27 17:55 ` Thomas Petazzoni
2013-10-28 8:01 ` Arnout Vandecappelle
2013-11-05 9:41 ` Fabio Porcedda
2013-10-18 9:34 ` [Buildroot] [PATCH v8 RESEND 3/8] package: add support for top-level parallel make Fabio Porcedda
2013-10-23 22:19 ` Arnout Vandecappelle
2013-11-11 9:36 ` Fabio Porcedda
2013-10-18 9:34 ` [Buildroot] [PATCH v8 RESEND 4/8] Makefile: " Fabio Porcedda
2013-10-23 22:29 ` Arnout Vandecappelle
2013-11-11 12:54 ` Fabio Porcedda
2013-10-23 22:40 ` Arnout Vandecappelle
2013-11-11 12:26 ` Fabio Porcedda
2013-10-18 9:34 ` [Buildroot] [PATCH v8 RESEND 5/8] glibc: " Fabio Porcedda
2013-10-23 22:48 ` Arnout Vandecappelle
2013-11-11 12:47 ` Fabio Porcedda
2013-10-18 9:34 ` [Buildroot] [PATCH v8 RESEND 6/8] uclibc: " Fabio Porcedda
2013-10-23 22:49 ` Arnout Vandecappelle
2013-11-11 12:50 ` Fabio Porcedda
2013-10-18 9:34 ` [Buildroot] [PATCH v8 RESEND 7/8] package: enable jobserver for recursive make Fabio Porcedda
2013-10-18 9:34 ` [Buildroot] [PATCH v8 RESEND 8/8] Makefile: enable top-level parallel make Fabio Porcedda
2013-10-23 21:09 ` [Buildroot] [PATCH v8 RESEND 0/8] Add support for " Arnout Vandecappelle
2013-11-11 13:49 ` Thomas Petazzoni
2013-11-12 8:39 ` Fabio Porcedda
2013-11-13 13:40 ` Fabio Porcedda
2013-11-13 20:05 ` Arnout Vandecappelle
2013-11-14 9:15 ` Fabio Porcedda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=526A27FA.10602@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox