Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] Config.in.legacy: select BR2_LEGACY for module-init-tools legacy option
@ 2013-11-07 19:09 Thomas Petazzoni
  2013-11-07 19:35 ` Thomas De Schampheleire
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2013-11-07 19:09 UTC (permalink / raw)
  To: buildroot

Commit 94c72087f3 ("module-init-tools: remove package") removed the
module-init-tools package and therefore added the corresponding config
option in Config.in.legacy. However, the commit forgot to add the
"select BR2_LEGACY" that ensures the build cannot proceed until the
user has acknowledged the change (i.e kmod replacing
module-init-tools).

This commit adds this missing "select BR2_LEGACY".

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 Config.in.legacy | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Config.in.legacy b/Config.in.legacy
index d02f0a6..587afe1 100644
--- a/Config.in.legacy
+++ b/Config.in.legacy
@@ -123,6 +123,7 @@ config BR2_PACKAGE_MODULE_INIT_TOOLS
 	bool "module-init-tools replaced by kmod"
 	select BR2_PACKAGE_KMOD
 	select BR2_PACKAGE_KMOD_TOOLS
+	select BR2_LEGACY
 	help
 	  The 'module-init-tools' package has been removed, since it
 	  has been depracated upstream and replaced by 'kmod'.
-- 
1.8.1.2

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH] Config.in.legacy: select BR2_LEGACY for module-init-tools legacy option
  2013-11-07 19:09 [Buildroot] [PATCH] Config.in.legacy: select BR2_LEGACY for module-init-tools legacy option Thomas Petazzoni
@ 2013-11-07 19:35 ` Thomas De Schampheleire
  2013-11-08  0:27 ` Arnout Vandecappelle
  2013-11-10 11:35 ` Peter Korsgaard
  2 siblings, 0 replies; 4+ messages in thread
From: Thomas De Schampheleire @ 2013-11-07 19:35 UTC (permalink / raw)
  To: buildroot

On Thu, Nov 7, 2013 at 8:09 PM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Commit 94c72087f3 ("module-init-tools: remove package") removed the
> module-init-tools package and therefore added the corresponding config
> option in Config.in.legacy. However, the commit forgot to add the
> "select BR2_LEGACY" that ensures the build cannot proceed until the
> user has acknowledged the change (i.e kmod replacing
> module-init-tools).
>
> This commit adds this missing "select BR2_LEGACY".
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Acked-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH] Config.in.legacy: select BR2_LEGACY for module-init-tools legacy option
  2013-11-07 19:09 [Buildroot] [PATCH] Config.in.legacy: select BR2_LEGACY for module-init-tools legacy option Thomas Petazzoni
  2013-11-07 19:35 ` Thomas De Schampheleire
@ 2013-11-08  0:27 ` Arnout Vandecappelle
  2013-11-10 11:35 ` Peter Korsgaard
  2 siblings, 0 replies; 4+ messages in thread
From: Arnout Vandecappelle @ 2013-11-08  0:27 UTC (permalink / raw)
  To: buildroot

On 07/11/13 20:09, Thomas Petazzoni wrote:
> Commit 94c72087f3 ("module-init-tools: remove package") removed the
> module-init-tools package and therefore added the corresponding config
> option in Config.in.legacy. However, the commit forgot to add the
> "select BR2_LEGACY" that ensures the build cannot proceed until the
> user has acknowledged the change (i.e kmod replacing
> module-init-tools).
>
> This commit adds this missing "select BR2_LEGACY".
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

> ---
>   Config.in.legacy | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/Config.in.legacy b/Config.in.legacy
> index d02f0a6..587afe1 100644
> --- a/Config.in.legacy
> +++ b/Config.in.legacy
> @@ -123,6 +123,7 @@ config BR2_PACKAGE_MODULE_INIT_TOOLS
>   	bool "module-init-tools replaced by kmod"
>   	select BR2_PACKAGE_KMOD
>   	select BR2_PACKAGE_KMOD_TOOLS
> +	select BR2_LEGACY
>   	help
>   	  The 'module-init-tools' package has been removed, since it
>   	  has been depracated upstream and replaced by 'kmod'.
>


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH] Config.in.legacy: select BR2_LEGACY for module-init-tools legacy option
  2013-11-07 19:09 [Buildroot] [PATCH] Config.in.legacy: select BR2_LEGACY for module-init-tools legacy option Thomas Petazzoni
  2013-11-07 19:35 ` Thomas De Schampheleire
  2013-11-08  0:27 ` Arnout Vandecappelle
@ 2013-11-10 11:35 ` Peter Korsgaard
  2 siblings, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2013-11-10 11:35 UTC (permalink / raw)
  To: buildroot

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 > Commit 94c72087f3 ("module-init-tools: remove package") removed the
 > module-init-tools package and therefore added the corresponding config
 > option in Config.in.legacy. However, the commit forgot to add the
 > "select BR2_LEGACY" that ensures the build cannot proceed until the
 > user has acknowledged the change (i.e kmod replacing
 > module-init-tools).

 > This commit adds this missing "select BR2_LEGACY".

 > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Committed, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2013-11-10 11:35 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-07 19:09 [Buildroot] [PATCH] Config.in.legacy: select BR2_LEGACY for module-init-tools legacy option Thomas Petazzoni
2013-11-07 19:35 ` Thomas De Schampheleire
2013-11-08  0:27 ` Arnout Vandecappelle
2013-11-10 11:35 ` Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox