From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] infra: introduce github helper function
Date: Wed, 13 Nov 2013 13:41:35 +0100 [thread overview]
Message-ID: <5283737F.9090703@mind.be> (raw)
In-Reply-To: <CAGduivx93_GbmnupCXxwnPXF_o-vGVnL+45WXUnXXdO+rf-Kng@mail.gmail.com>
On 13/11/13 13:37, Maxime Hadjinlian wrote:
> Hi everyone,
>
> Thanks you Mischa for creating this patch.
>
> How about a dedicated URI scheme like
> github://<username>/<package>/<version> instead of a call to a macro ?
> I find it easier to remember, less error prone and maybe more user friendly.
Easier to remember: maybe.
Less error prone: how so? Admittedly, with the call you won't get an
error if you forget the third argument, but you will get an error if you
forget e.g. the $(call ...) part.
However, the killer argument is: the implementation of this helper
function is quite trivial, while the implementation of a github URL
parser would be a lot more complicated.
Bottom line: I like it the way it is.
That said, feel free to post an alternative patch :-)
Regards,
Arnout
[snip]
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
next prev parent reply other threads:[~2013-11-13 12:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-13 12:24 [Buildroot] [PATCH v2] infra: introduce github helper function Mischa Jonker
2013-11-13 12:37 ` Arnout Vandecappelle
2013-11-13 12:37 ` Maxime Hadjinlian
2013-11-13 12:41 ` Mischa Jonker
2013-11-13 12:41 ` Arnout Vandecappelle [this message]
2013-11-13 12:49 ` Maxime Hadjinlian
2013-11-13 13:15 ` Thomas De Schampheleire
2013-11-13 13:33 ` Arnout Vandecappelle
2013-11-13 13:44 ` Thomas De Schampheleire
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5283737F.9090703@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox