From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnout Vandecappelle Date: Wed, 13 Nov 2013 21:05:14 +0100 Subject: [Buildroot] [PATCH v8 RESEND 0/8] Add support for top-level parallel make In-Reply-To: References: <1382088860-30524-1-git-send-email-fabio.porcedda@gmail.com> <20131111144953.43bd80b0@skate> Message-ID: <5283DB7A.6060901@mind.be> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net On 12/11/13 09:39, Fabio Porcedda wrote: > On Mon, Nov 11, 2013 at 2:49 PM, Thomas Petazzoni > wrote: >> Fabio, Arnout, >> >> On Fri, 18 Oct 2013 11:34:12 +0200, Fabio Porcedda wrote: >> >>> this is a patch set for adding support for top-level parallel make in >>> buildroot, the common problem scattered in buildroot's top-level >>> makefiles is that in the rules it relies on the order of evaluation of >>> the prerequisites, to be able to use top-level parallel make instead >>> of reling on the left to right ordering of evaluation of the >>> prerequisites we must add an explicit rule to describe the >>> dependencies. >> >> I'd like to agree on a plan with this patch series. At the latest >> Buildroot Developer Day in Edinburgh, I think we agreed that: >> >> (1) Enabling top-level parallel without having per-package sysroot was >> not desirable, as it would make the builds non-reproducible. > > What do you think if we provide an easy way to use top-level parallel make > that warns about the problems: > > ifeq ($(P),1) > $(warning Not reproducible builds use at your own risk!) Such a warning will not really be visible, because it appears at the very beginning of the build and is immediately followed by all of the build output... > BR2_JLEVEL= > else > # This top-level Makefile can *not* be executed in parallel > .NOTPARALLEL: > endif Since you only need to make this simple change in the Makefile (remove .NOTPARALLEL), I think it's a lot more effective for people who want top-level parallel builds to remove this line in their copy of buildroot. We also agreed at the BR developer meeting that we would add an explanatory comment at that location to make it clear why we disable parallel builds. That way, someone who wants to enable it will be aware of the risks. Regards, Arnout > > > make P=1 -j5 [snip] -- Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F