From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] pciutils: install static lib with shared
Date: Tue, 19 Nov 2013 23:47:24 +0100 [thread overview]
Message-ID: <528BEA7C.8040700@mind.be> (raw)
In-Reply-To: <F9C551623D2CBB4C9488801D14F864C663264BB0@ex-mb1.corp.adtran.com>
On 18/11/13 21:02, ANDY KENNEDY wrote:
> When building pciutils as shared, also include the static libraries for
> a more rounded staging directory (useful when PREFER_STATIC_LIB is not
> set, but should provide a static library for when static linking with
> libpci is preferred).
>
> Signed-off-by: Andy Kennedy <andy.kennedy@adtran.com>
> ---
> diff -Naur a/package/pciutils/pciutils.mk b/package/pciutils/pciutils.mk
> --- a/package/pciutils/pciutils.mk 2013-09-17 06:42:07.000000000 -0500
> +++ b/package/pciutils/pciutils.mk 2013-11-18 13:49:31.000000000 -0600
> @@ -17,7 +17,26 @@
> PCIUTILS_ZLIB=no
> endif
> PCIUTILS_DNS=no
> +ifeq ($(BR2_PREFER_STATIC_LIB),y)
> +PCIUTILS_SHARED=no
> +PCIUTILS_DO_SHARED_BUILD =
> +else
> PCIUTILS_SHARED=yes
> +define PCIUTILS_DO_SHARED_BUILD
> + $(TARGET_MAKE_ENV) $(MAKE) CC="$(TARGET_CC)" \
> + HOST="$(KERNEL_ARCH)-linux" \
> + OPT="$(TARGET_CFLAGS)" \
> + LDFLAGS="$(TARGET_LDFLAGS)" \
> + RANLIB=$(TARGET_RANLIB) \
> + AR=$(TARGET_AR) \
> + -C $(PCIUTILS_DIR) \
> + SHARED=yes \
> + ZLIB=$(PCIUTILS_ZLIB) \
> + DNS=$(PCIUTILS_DNS) \
> + LIBKMOD=$(PCIUTILS_KMOD) \
> + PREFIX=/usr
This should be refactored so the long list of arguments isn't repeated.
E.g.
PCIUTILS_MAKE_OPTS = \
CC="$(TARGET_CC)" \
...
define PCIUTILS_DO_SHARED_BUILD
$(TARGET_MAKE_ENV) $(MAKE) -C @(D) \
$(PCIUTILS_MAKE_OPTS) SHARED=yes
endef
> +endef
> +endif
>
> # Build after busybox since it's got a lightweight lspci
> ifeq ($(BR2_PACKAGE_BUSYBOX),y)
> @@ -47,11 +66,12 @@
> RANLIB=$(TARGET_RANLIB) \
> AR=$(TARGET_AR) \
> -C $(PCIUTILS_DIR) \
> - SHARED=$(PCIUTILS_SHARED) \
> + SHARED=no \
> ZLIB=$(PCIUTILS_ZLIB) \
> DNS=$(PCIUTILS_DNS) \
> LIBKMOD=$(PCIUTILS_KMOD) \
> PREFIX=/usr
> + $(PCIUTILS_DO_SHARED_BUILD)
> endef
>
> # Ditch install-lib if SHARED is an option in the future
As this comment says, for the static case, install-lib is not necessary
for the target install.
Wouldn't the install commands have to be done twice as well for staging?
Regards,
Arnout
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
next prev parent reply other threads:[~2013-11-19 22:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-18 20:02 [Buildroot] [PATCH] pciutils: install static lib with shared ANDY KENNEDY
2013-11-19 22:47 ` Arnout Vandecappelle [this message]
2013-11-19 23:39 ` ANDY KENNEDY
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=528BEA7C.8040700@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox