Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Mark MIPS I, II, III and IV as deprecated
Date: Wed, 20 Nov 2013 11:51:36 +0000	[thread overview]
Message-ID: <528CA248.70505@imgtec.com> (raw)
In-Reply-To: <20131120120900.6a66d750@skate>

On 11/20/2013 11:09 AM, Thomas Petazzoni wrote:
> Dear Vicente Olivert Riera,
>
> On Wed, 20 Nov 2013 10:42:53 +0000, Vicente Olivert Riera wrote:
>> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
>> ---
>>   arch/Config.in.mips |    6 ++++--
>>   1 files changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/Config.in.mips b/arch/Config.in.mips
>> index d70fd63..43af33c 100644
>> --- a/arch/Config.in.mips
>> +++ b/arch/Config.in.mips
>> @@ -12,14 +12,16 @@ choice
>>
>>   config BR2_mips_1
>>   	bool "mips I (generic)"
>> -	depends on !BR2_ARCH_IS_64
>> +	depends on !BR2_ARCH_IS_64 && BR2_DEPRECATED
>>   config BR2_mips_2
>>   	bool "mips II"
>> -	depends on !BR2_ARCH_IS_64
>> +	depends on !BR2_ARCH_IS_64 && BR2_DEPRECATED
>>   config BR2_mips_3
>>   	bool "mips III"
>> +	depends on BR2_DEPRECATED
>>   config BR2_mips_4
>>   	bool "mips IV"
>> +	depends on BR2_DEPRECATED
>>   config BR2_mips_32
>>   	bool "mips 32"
>>   	depends on !BR2_ARCH_IS_64
>
> The commit log should explain *why* we're deprecating these CPU
> variants.
>
> Moreover, if we deprecate mips_1 and mips_3, then there should be some
> change in:
>
> choice
>          prompt "Target Architecture Variant"
>          depends on BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el
>          default BR2_mips_3 if BR2_mips
>          default BR2_mips_1 if BR2_mipsel
>          default BR2_mips_64 if BR2_mips64 || BR2_mips64el
>          help
>
> at the beginning of Config.in.mips
>
> Thomas
>

Thanks for your help Thomas. I have sent a V2.

-- 
Vincent

      reply	other threads:[~2013-11-20 11:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-20 10:42 [Buildroot] [PATCH] Mark MIPS I, II, III and IV as deprecated Vicente Olivert Riera
2013-11-20 11:09 ` Thomas Petazzoni
2013-11-20 11:51   ` Vicente Olivert Riera [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=528CA248.70505@imgtec.com \
    --to=vincent.riera@imgtec.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox