Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] Add support to set the default port for dropbear to listen on
Date: Fri, 22 Nov 2013 21:17:30 +0100	[thread overview]
Message-ID: <528FBBDA.6020105@mind.be> (raw)
In-Reply-To: <1485435858.899015.1385143819916.JavaMail.root@telenet.be>

On 22/11/13 19:10, jeroen.de.wachter at telenet.be wrote:
> A menu entry has been added to set the port. This menu entry
> is processed like entries that were already present and will
> rewrite one line of the options.h file that is used by
> dropbear during compilation.
>
> Signed-off-by: Jeroen De Wachter<jeroen.de_wachter@alcatel-lucent.com>

  Hi Jeroen,

  Thank you for your patch. However, I don't think we will accept it in 
buildroot. We could make thousands of configuration options that deal 
with all possible fine-grained tweaking. And especially in this 
particular case, the option is quite invasive (requires 5 additional 
lines in the .mk file) and it is possible to achieve the same result by 
adding a command-line option to dropbear, by including a custom 
S50dropbear to your fs-overlay.

  But of course, our friendly maintainer may be of a different opinion.

  The patch itself looks good BTW, except that indentation should be with 
a tab (tab + 2 spaces for the Config.in help text).

  Regards,
  Arnout

[snip]

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

  parent reply	other threads:[~2013-11-22 20:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-22 18:10 [Buildroot] [PATCH 1/1] Add support to set the default port for dropbear to listen on jeroen.de.wachter at telenet.be
2013-11-22 19:52 ` Thomas De Schampheleire
2013-11-22 20:17 ` Arnout Vandecappelle [this message]
2013-11-22 20:58   ` Yann E. MORIN
2013-11-22 22:14 ` Peter Korsgaard
2013-12-03  4:04 ` [Buildroot] Moschip MCS8142 SoC Matthew Weber
2013-12-03  4:52   ` Baruch Siach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=528FBBDA.6020105@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox