From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnout Vandecappelle Date: Mon, 25 Nov 2013 12:02:18 +0100 Subject: [Buildroot] [PATCH] lvm2: replace !BR2_PACKAGE_LVM2_DMSETUP_ONLY by BR2_PACKAGE_LVM2_FULL_SUITE In-Reply-To: References: <20131123183721.071bcfa1@skate> <1385250624-15984-1-git-send-email-arnout@mind.be> Message-ID: <52932E3A.2080903@mind.be> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net On 25/11/13 10:46, Thomas De Schampheleire wrote: > Hi Arnout, > > On Sun, Nov 24, 2013 at 12:50 AM, Arnout Vandecappelle > (Essensium/Mind) wrote: [snip] >> +config BR2_PACKAGE_LVM2_DMSETUP_ONLY >> + bool "lvm2's 'dmsetup only' option removed" >> + select BR2_LEGACY >> + help >> + The BR2_PACKAGE_LVM2_DMSETUP_ONLY was a negative option, which >> + led to problems with other packages that need the full lvm2 >> + suite. Therefore, the option has been replaced with the positive >> + BR2_PACKAGE_LVM2_FULL_SUITE option. >> + > > There should be a comment here that refers to the remaining legacy > reference in package/lvm2/Config.in, see > comment at BR2_TARGET_UBOOT_CUSTOM_GIT_REPO_URL_WRAP. True, I forgot about that. Thanks. > >> config BR2_PACKAGE_QT_JAVASCRIPTCORE >> bool "qt javascriptcore option removed" >> select BR2_LEGACY >> diff --git a/package/lvm2/Config.in b/package/lvm2/Config.in >> index b3988ea..849aab3 100644 >> --- a/package/lvm2/Config.in >> +++ b/package/lvm2/Config.in >> @@ -16,16 +16,18 @@ config BR2_PACKAGE_LVM2 >> user-space. This makes it useful for not only LVM, but EVMS, >> software raid, and other drivers that create "virtual" block devices. >> >> -config BR2_PACKAGE_LVM2_DMSETUP_ONLY >> - bool "install dmsetup only" >> +config BR2_PACKAGE_LVM2_FULL_SUITE >> + bool "install the full LVM2 suite" >> + default y if !BR2_PACKAGE_LVM2_DMSETUP_ONLY # legacy 2013.11 >> depends on BR2_PACKAGE_LVM2 >> help >> - Install dmsetup only and skip the LVM2 suite. >> + Install the full LVM2 suite. When this option is not set, only >> + dmsetup is installed. >> >> config BR2_PACKAGE_LVM2_APP_LIBRARY >> bool "install application library" >> depends on BR2_PACKAGE_LVM2 >> - depends on !BR2_PACKAGE_LVM2_DMSETUP_ONLY >> + select BR2_PACKAGE_LVM2_FULL_SUITE >> help >> Install application library (liblvm2app). > > It seems odd to me that the 'full suite' does not include the app > library: it is not 'full'. Granted, but I can't think of a better name. Anyone? > It would have been nice if we could have options for the different > components, but at first sight there seem to be quite a number of > components in lvm2: (rough estimate below) Yeah, and that would anyway be a separate patch. Regards, Arnout [snip] -- Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F