From: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/2] qt: Disable QtScript on MIPS64
Date: Thu, 28 Nov 2013 13:49:06 +0000 [thread overview]
Message-ID: <529749D2.7010404@imgtec.com> (raw)
In-Reply-To: <20131128130741.085cb04e@skate>
On 11/28/2013 12:07 PM, Thomas Petazzoni wrote:
> Dear Vicente Olivert Riera,
>
> On Wed, 27 Nov 2013 17:10:06 +0000, Vicente Olivert Riera wrote:
>
>> diff --git a/package/qt/Config.in b/package/qt/Config.in
>> index 2651d55..dd2b6d9 100644
>> --- a/package/qt/Config.in
>> +++ b/package/qt/Config.in
>> @@ -385,6 +385,7 @@ config BR2_PACKAGE_QT_OPENSSL
>>
>> config BR2_PACKAGE_QT_SCRIPT
>> bool "Script Module"
>> + depends on BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT
>
> I'm wondering if we shouldn't rename this option to something more
> exact: ARCH_SUPPORTS_JAVASCRIPTCORE. But I don't know, and we don't
> have well established best practices for this kind of things.
>
> Thomas
>
Maybe we could keep it as is by now, apply the quick fix for the next
release, and decide what to do in the future. What do you think?
--
Vincent
next prev parent reply other threads:[~2013-11-28 13:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-27 17:10 [Buildroot] [PATCH v2 1/2] qt: Disable QtScript on MIPS64 Vicente Olivert Riera
2013-11-27 17:10 ` [Buildroot] [PATCH v2 2/2] grantlee: Disable " Vicente Olivert Riera
2013-11-28 10:26 ` [Buildroot] [PATCH v2 1/2] qt: Disable QtScript " Markos Chandras
2013-11-28 10:28 ` Markos Chandras
2013-11-28 10:48 ` Vicente Olivert Riera
2013-11-28 12:07 ` Thomas Petazzoni
2013-11-28 13:49 ` Vicente Olivert Riera [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-11-27 13:42 Vicente Olivert Riera
2013-11-27 14:03 ` Thomas Petazzoni
2013-11-27 17:11 ` Vicente Olivert Riera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529749D2.7010404@imgtec.com \
--to=vincent.riera@imgtec.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox