Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jerzy Grzegorek <jerzy.grzegorek@trzebnica.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/3] package/parted: relax dependency on readline
Date: Sat, 07 Dec 2013 10:48:05 +0100	[thread overview]
Message-ID: <52A2EED5.3090907@trzebnica.net> (raw)
In-Reply-To: <7877131b94507ff84d258422f549b689e29e71a3.1386359706.git.yann.morin.1998@free.fr>


Hi Yann,

> From: "Yann E. MORIN" <yann.morin.1998@free.fr>
>
> parted can be configured without support for readline (ie. can be
> not interactive), so we can relax the dependency on lvm2, and make
> it an optional feature.

lvm2 ?
s/lvm2/readline/

Regards,
Jerzy

>
> (Based on a code-snippet from Thomas.)
>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> ---
>   package/parted/Config.in | 1 -
>   package/parted/parted.mk | 9 ++++++++-
>   2 files changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/package/parted/Config.in b/package/parted/Config.in
> index 321fdf7..45170aa 100644
> --- a/package/parted/Config.in
> +++ b/package/parted/Config.in
> @@ -2,7 +2,6 @@ config BR2_PACKAGE_PARTED
>   	bool "parted"
>   	depends on BR2_LARGEFILE
>   	depends on BR2_USE_WCHAR
> -	select BR2_PACKAGE_READLINE
>   	select BR2_PACKAGE_UTIL_LINUX
>   	select BR2_PACKAGE_UTIL_LINUX_LIBUUID
>   	help
> diff --git a/package/parted/parted.mk b/package/parted/parted.mk
> index 231ab35..afb8287 100644
> --- a/package/parted/parted.mk
> +++ b/package/parted/parted.mk
> @@ -7,11 +7,18 @@
>   PARTED_VERSION = 3.1
>   PARTED_SOURCE = parted-$(PARTED_VERSION).tar.xz
>   PARTED_SITE = $(BR2_GNU_MIRROR)/parted
> -PARTED_DEPENDENCIES = readline util-linux
> +PARTED_DEPENDENCIES = util-linux
>   PARTED_INSTALL_STAGING = YES
>   PARTED_LICENSE = GPLv3+
>   PARTED_LICENSE_FILES = COPYING
>   
> +ifeq ($(BR2_PACKAGE_READLINE),y)
> +PARTED_DEPENDENCIES += readline
> +PARTED_CONF_OPT += --with-readline
> +else
> +PARTED_CONF_OPT += --without-readline
> +endif
> +
>   ifeq ($(BR2_PACKAGE_LVM2),y)
>   PARTED_DEPENDENCIES += lvm2
>   PARTED_CONF_OPT += --enable-device-mapper

  reply	other threads:[~2013-12-07  9:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-06 19:57 [Buildroot] [pull request v2] Pull request for branch yem/host-packages Yann E. MORIN
2013-12-06 19:57 ` [Buildroot] [PATCH 1/3] package/parted: relax dependency on lvm2 Yann E. MORIN
2013-12-06 19:57 ` [Buildroot] [PATCH 2/3] package/parted: relax dependency on readline Yann E. MORIN
2013-12-07  9:48   ` Jerzy Grzegorek [this message]
2013-12-07 19:26     ` Yann E. MORIN
2013-12-06 19:57 ` [Buildroot] [PATCH 3/3] package/parted: add a host variant Yann E. MORIN
  -- strict thread matches above, loose matches on Subject: below --
2013-12-08 17:01 [Buildroot] [pull request v3] Pull request for branch yem/host-packages Yann E. MORIN
2013-12-08 17:01 ` [Buildroot] [PATCH 2/3] package/parted: relax dependency on readline Yann E. MORIN
2013-12-12 18:18 [Buildroot] [pull request v4] Pull request for branch yem/host-packages Yann E. MORIN
2013-12-12 18:18 ` [Buildroot] [PATCH 2/3] package/parted: relax dependency on readline Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52A2EED5.3090907@trzebnica.net \
    --to=jerzy.grzegorek@trzebnica.net \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox