From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Corvoysier Date: Wed, 11 Dec 2013 14:03:48 +0100 Subject: [Buildroot] [PATCH] package/libgles: postpone the check for a missing GLES provider In-Reply-To: <201312111325.49600.yann.morin.1998@free.fr> References: <52A730B0.3020104@orange.com> <1386702439-10093-2-git-send-email-yann.morin.1998@free.fr> <52A842A3.3010302@mind.be> <201312111325.49600.yann.morin.1998@free.fr> Message-ID: <52A862B4.50103@orange.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Guys, The first solution did not work (as yann pointed out, the variable is not exported), but the second does. Who's in for a patch (me ?) David Le 11/12/2013 13:25, Yann E. MORIN a ?crit : > Arnout, All, > > On Wednesday 11 December 2013 11:46:59 Arnout Vandecappelle wrote: >> On 10/12/13 20:07, Yann E. MORIN wrote: >>> From: "Yann E. MORIN" >>> >>> Because some GLES providers may be in BR2_EXTERNAL, $(LIBGLES_DEPENDENCIES) >>> might be empty hwen we test it. >>> >>> So, we can't rely on it to define LIBGLES_CONFIGURE_CMDS, and we must >>> postpone the check until later, ie. at runtime. >>> >>> Signed-off-by: "Yann E. MORIN" >>> --- >>> package/opengl/libgles/libgles.mk | 13 +++++++++---- >>> 1 file changed, 9 insertions(+), 4 deletions(-) >>> >>> diff --git a/package/opengl/libgles/libgles.mk b/package/opengl/libgles/libgles.mk >>> index ec157ac..c2e1acf 100644 >>> --- a/package/opengl/libgles/libgles.mk >>> +++ b/package/opengl/libgles/libgles.mk >>> @@ -22,11 +22,16 @@ ifeq ($(BR2_PACKAGE_GPU_VIV_BIN_MX6Q),y) >>> LIBGLES_DEPENDENCIES += gpu-viv-bin-mx6q >>> endif >>> >>> -ifeq ($(LIBGLES_DEPENDENCIES),) >>> +# Because some GLES providers may be in BR2_EXTERNAL, >>> +# $(LIBGLES_DEPENDENCIES) might be empty right here. >>> +# So, we can't rely on it to define LIBGLES_CONFIGURE_CMDS >>> +# right now, and we must postpone the check until later, >>> +# ie. at runtime. >>> define LIBGLES_CONFIGURE_CMDS >>> - echo "No libGLES implementation selected. Configuration error." >>> - exit 1 >>> + if [ -z "$${LIBGLES_DEPENDENCIES}" ]; then \ >> This should be "$(LIBGLES_DEPENDENCIES)", but otherwise it looks like >> it would work. > I was afraid using a make variable here would be expanded too early > again, that's why I postponed its expansion into the shell command > itself. > > But it does not work either, since the variable is not exported. > > I'm waiting for feedback from David to confirm either or both > solutions work... > > Regards, > Yann E. MORIN. >