Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jerzy Grzegorek <jerzy.grzegorek@trzebnica.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package: add <pkg>_VERSION_MAJOR variable
Date: Thu, 19 Dec 2013 09:01:55 +0100	[thread overview]
Message-ID: <52B2A7F3.3090105@trzebnica.net> (raw)
In-Reply-To: <CAAXf6LUCm6YnYV4yWXYrEJcq7b-xkJKRzr8AbQwpwMjO9Osa8g@mail.gmail.com>


Hi Thomas,

Thanks for your review.

> On Wed, Dec 18, 2013 at 7:20 PM, Jerzy Grzegorek
> <jerzy.grzegorek@trzebnica.net> wrote:
>> Signed-off-by: Jerzy Grzegorek <jerzy.grzegorek@trzebnica.net>
>> ---
>>   package/cmake/cmake.mk               |    5 +++--
>>   package/gnutls/gnutls.mk             |    5 +++--
>>   package/gtk2-engines/gtk2-engines.mk |    5 +++--
>>   package/ipsec-tools/ipsec-tools.mk   |    5 +++--
>>   package/libart/libart.mk             |    5 +++--
>>   package/libglade/libglade.mk         |    5 +++--
>>   package/libsigc/libsigc.mk           |    5 +++--
>>   package/lighttpd/lighttpd.mk         |    5 +++--
>>   package/linphone/linphone.mk         |    5 +++--
>>   package/midori/midori.mk             |    5 +++--
>>   package/mysql_client/mysql_client.mk |    5 +++--
>>   package/nano/nano.mk                 |    5 +++--
>>   package/ntp/ntp.mk                   |    5 +++--
>>   package/nut/nut.mk                   |    5 +++--
>>   package/qt/qt.mk                     |    5 +++--
>>   package/qt5/qt5.mk                   |    5 +++--
>>   package/rpm/rpm.mk                   |    5 +++--
>>   package/ruby/ruby.mk                 |    5 +++--
>>   package/sdl_gfx/sdl_gfx.mk           |    5 +++--
>>   package/squid/squid.mk               |    5 +++--
>>   20 files changed, 60 insertions(+), 40 deletions(-)
> Reviewed-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
>
>
> Jerzy: how did you determine the list of files to change? Manually
> opening all of them, or some more automated method?

I used the automated method.

Regards,
Jerzy

>
> Thanks,
> Thomas
>

  reply	other threads:[~2013-12-19  8:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-18 18:20 [Buildroot] [PATCH 1/1] package: add <pkg>_VERSION_MAJOR variable Jerzy Grzegorek
2013-12-18 20:39 ` Thomas De Schampheleire
2013-12-19  8:01   ` Jerzy Grzegorek [this message]
2013-12-19  8:09     ` Thomas De Schampheleire
2013-12-19  8:37       ` Jerzy Grzegorek
2013-12-19  8:50         ` Thomas De Schampheleire
2013-12-19 10:16           ` Jerzy Grzegorek
2013-12-19 20:38 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52B2A7F3.3090105@trzebnica.net \
    --to=jerzy.grzegorek@trzebnica.net \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox