From: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] luarocks: fix compilation on 64bits
Date: Wed, 15 Jan 2014 11:57:52 +0000 [thread overview]
Message-ID: <52D677C0.4020504@imgtec.com> (raw)
In-Reply-To: <CAB0FRstP_cEdRwAKjiF2qVYicWP9XaVQKbPFL9oFUaiqM5Wq7w@mail.gmail.com>
On 01/15/2014 10:49 AM, Fran?ois Perrad wrote:
> 2014/1/15 Peter Korsgaard <jacmet@uclibc.org>:
>>>>>>> "Francois" == Francois Perrad <fperrad@gmail.com> writes:
>>
>> > Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
>>
>> Where did you see this? On the autobuilders? If yes, please add a link.
>>
>
> in the latest autobuilder report, native Lua modules using the
> `luarocks-package` infrastructure are broken :
> x86_64 | lbase64-20120820-1 | NOK |
> http://autobuild.buildroot.net/results/f28a624f89f4de249a1b7a718f5ae31109ba9171/
> x86_64 | luabitop-1.0.2-1 | NOK |
> http://autobuild.buildroot.net/results/1ead0a162a251d3e7bf8598036fa06c4befeb3d9/
> x86_64 | luaexpat-1.2.0-1 | NOK |
> http://autobuild.buildroot.net/results/0544cead086ba51b45dfa1df114787a8f22eaf8d/
> x86_64 | luafilesystem-1.6.2-1 | NOK |
> http://autobuild.buildroot.net/results/60161d13d596d41dd4059977eb947d72c172f0d5/
>
>> It's not really about 32bits/64bits, but yes, x86-64 is one of the archs
>> needing -fPIC.
>
> Yes, x86_64
>
>>
>> > ---
>> > package/luarocks/luarocks.mk | 2 +-
>> > 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> > diff --git a/package/luarocks/luarocks.mk b/package/luarocks/luarocks.mk
>> > index 85b6866..6cfd92e 100644
>> > --- a/package/luarocks/luarocks.mk
>> > +++ b/package/luarocks/luarocks.mk
>> > @@ -31,7 +31,7 @@ define HOST_LUAROCKS_INSTALL_CMDS
>> > echo " LUA_LIBDIR = [[$(STAGING_DIR)/usr/lib]]," >> $(LUAROCKS_CONFIG_FILE)
>> > echo " CC = [[$(TARGET_CC)]]," >> $(LUAROCKS_CONFIG_FILE)
>> > echo " LD = [[$(TARGET_CC)]]," >> $(LUAROCKS_CONFIG_FILE)
>> > - echo " CFLAGS = [[$(TARGET_CFLAGS)]]," >> $(LUAROCKS_CONFIG_FILE)
>> > + echo " CFLAGS = [[$(TARGET_CFLAGS) -fPIC]]," >> $(LUAROCKS_CONFIG_FILE)
>> > echo " LIBFLAG = [[-shared $(TARGET_LDFLAGS)]]," >> $(LUAROCKS_CONFIG_FILE)
>>
>> What about BR2_PREFER_STATIC_LIB (for both CFLAGS and LDFLAGS lines)?
>
> native Lua modules/extensions are always shared lib.
>
>>
>> --
>> Bye, Peter Korsgaard
>> _______________________________________________
>> buildroot mailing list
>> buildroot at busybox.net
>> http://lists.busybox.net/mailman/listinfo/buildroot
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>
I have tested this patch on mips. It fixes this problem:
http://autobuild.buildroot.net/results/e7e/e7ea6946552f72dc27f23ae1aff1665a6aa097c7/
--
Vincent
next prev parent reply other threads:[~2014-01-15 11:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-15 8:42 [Buildroot] [PATCH] luarocks: fix compilation on 64bits Francois Perrad
2014-01-15 10:12 ` Peter Korsgaard
2014-01-15 10:49 ` François Perrad
2014-01-15 11:57 ` Vicente Olivert Riera [this message]
2014-01-15 12:14 ` Peter Korsgaard
2014-01-15 12:59 ` Mike Zick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D677C0.4020504@imgtec.com \
--to=vincent.riera@imgtec.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox