Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Gustavo Zacarias <gustavo@zacarias.com.ar>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCHv2] e2fsprogs: Install libraries to staging
Date: Wed, 22 Jan 2014 10:13:42 -0300	[thread overview]
Message-ID: <52DFC406.8080504@zacarias.com.ar> (raw)
In-Reply-To: <20131128192305.154ec187@skate>

On 11/28/2013 03:23 PM, Thomas Petazzoni wrote:
>> +E2FSPROGS_INSTALL_STAGING = YES
>> +E2FSPROGS_INSTALL_STAGING_OPT = DESTDIR=$(STAGING_DIR) install-libs
> 
> I must say I'd like to know *why* the normal "install" rule does not
> install the .pc file. It seems to install everything else, including
> the libraries, but not the .pc file, for some reason.

Fair enough, when calling install in the toplevel Makefile.in calling
install-libs has some conditions:

if test ! -d e2fsck && test ! -d debugfs && test ! -d misc && test ! -d
ext2ed ; then $(MAKE) install-libs ; fi

Since those directories exist install-libs is never called internally,
just install-shlibs-recursive which doesn't install the pc files.

My $.02 guess is that rule was written for e2fsprogs-libs which is the
recommended way to get the libs (blkid/et/quota/ss/uuid) since it lacks
those directories and has the same condition on the toplevel Makefile.in

It might be worth analyzing if we want to split, some distros do it that
way and it would reduce build times a bit in some scenarios.

Regards.

  parent reply	other threads:[~2014-01-22 13:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-28 17:53 [Buildroot] [PATCHv2] e2fsprogs: Install libraries to staging Daniel Nyström
2013-11-28 18:23 ` Thomas Petazzoni
2013-11-30 21:26   ` Arnout Vandecappelle
2014-01-22 13:13   ` Gustavo Zacarias [this message]
2014-01-22 13:08 ` Gustavo Zacarias
2014-01-22 20:45   ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52DFC406.8080504@zacarias.com.ar \
    --to=gustavo@zacarias.com.ar \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox