From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2 of 4 v2] infra: remove usage of 4th parameter to inner-generic-package
Date: Tue, 04 Feb 2014 18:46:33 +0100 [thread overview]
Message-ID: <52F12779.7000008@mind.be> (raw)
In-Reply-To: <7a542b87fe6e904a88f6.1391530914@argentina>
On 04/02/14 17:21, Thomas De Schampheleire wrote:
> In preparation of the removal of the 4th parameter to inner-generic-package
> and the pkgparentdir helper function, this patch removes the direct usage of
> this 4th parameter. The remaining usage
> ifeq ($(4),boot/)
> can become
> $(filter boot/%,$(call pkgdir))
> instead (and similar for toolchain).
>
> Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
>
> ---
> package/pkg-generic.mk | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk
> --- a/package/pkg-generic.mk
> +++ b/package/pkg-generic.mk
> @@ -516,9 +516,9 @@ endif
> # kernel case, the bootloaders case, and the normal packages case.
> ifeq ($(1),linux)
> $(2)_KCONFIG_VAR = BR2_LINUX_KERNEL
> -else ifeq ($(4),boot/)
> +else ifneq ($(filter boot/%,$(call pkgdir)),)
AFAICS the call is redundant here.
Yes, I know it's there in the pkgname definition, but there's no need to
repeate past mistakes :-)
(The call construct is only needed for macros that take arguments. It's
another example of make insanity...)
Regards,
Arnout
> $(2)_KCONFIG_VAR = BR2_TARGET_$(2)
> -else ifeq ($(4),toolchain/)
> +else ifneq ($(filter toolchain/%,$(call pkgdir)),)
> $(2)_KCONFIG_VAR = BR2_$(2)
> else
> $(2)_KCONFIG_VAR = BR2_PACKAGE_$(2)
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
next prev parent reply other threads:[~2014-02-04 17:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-04 16:21 [Buildroot] [PATCH 0 of 4 v2] infra: remove FOO_DIR_PREFIX, 4th param of pkg infras, pkgparentdir Thomas De Schampheleire
2014-02-04 16:21 ` [Buildroot] [PATCH 1 of 4 v2] infra: remove variable FOO_DIR_PREFIX Thomas De Schampheleire
2014-02-04 17:55 ` Arnout Vandecappelle
2014-02-04 20:02 ` Yann E. MORIN
2014-02-04 16:21 ` [Buildroot] [PATCH 2 of 4 v2] infra: remove usage of 4th parameter to inner-generic-package Thomas De Schampheleire
2014-02-04 17:46 ` Arnout Vandecappelle [this message]
2014-02-04 16:21 ` [Buildroot] [PATCH 3 of 4 v2] infra: remove unused 4th parameter to package infrastructures (pkgparentdir) Thomas De Schampheleire
2014-02-04 16:21 ` [Buildroot] [PATCH 4 of 4 v2] infra: remove unused helper function pkgparentdir Thomas De Schampheleire
2014-02-04 17:55 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52F12779.7000008@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox