From mboxrd@z Thu Jan  1 00:00:00 1970
From: Arnout Vandecappelle <arnout@mind.be>
Date: Thu, 06 Feb 2014 07:23:53 +0100
Subject: [Buildroot] [PATCH v3 2/3] libdrm: Remove dependency towards X11
In-Reply-To: <BLU0-SMTP32389AD6A8E820FAAACD353D9950@phx.gbl>
References: <1391633362-30331-1-git-send-email-berndkuhls@hotmail.com>
 <BLU0-SMTP32389AD6A8E820FAAACD353D9950@phx.gbl>
Message-ID: <52F32A79.5070501@mind.be>
List-Id: <buildroot.busybox.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: buildroot@busybox.net

On 05/02/14 21:49, Bernd Kuhls wrote:
> v4: remove unnecessary dependencies (Arnout)
> v3: rebased v2
> v2: http://patchwork.ozlabs.org/patch/304116/ (Paul Cercueil)
> v1: http://patchwork.ozlabs.org/patch/278297/ (Spenser Gilliland)

 Same comment about the place of the patch changelog.

 Also, for this one you should put in the commit message your proof that
these dependencies can be removed. Basically, the body of the mail you
sent earlier.

> 
> Signed-off-by: Bernd Kuhls <berndkuhls@hotmail.com>
> Signed-Off-By: Paul Cercueil <paul@crapouillou.net>
> Signed-off-by: Spenser Gilliland <spenser@gillilanding.com>

Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

 Regards,
 Arnout

> ---
>  package/libdrm/Config.in |    7 +------
>  package/libdrm/libdrm.mk |    3 ---
>  2 files changed, 1 insertion(+), 9 deletions(-)
> 
> diff --git a/package/libdrm/Config.in b/package/libdrm/Config.in
> index 4d7646b..7192e94 100644
> --- a/package/libdrm/Config.in
> +++ b/package/libdrm/Config.in
> @@ -1,7 +1,6 @@
>  config BR2_PACKAGE_LIBDRM
>  	bool "libdrm"
>  	select BR2_PACKAGE_LIBPTHREAD_STUBS
> -	depends on BR2_PACKAGE_XORG7
>  	depends on BR2_LARGEFILE
>  	help
>  	  Direct Rendering Manager
> @@ -14,6 +13,7 @@ menu "DRM Drivers"
>  
>  config BR2_PACKAGE_LIBDRM_INTEL
>  	bool "intel"
> +	depends on BR2_PACKAGE_XORG7
>  	select BR2_PACKAGE_LIBATOMIC_OPS
>  	select BR2_PACKAGE_XLIB_LIBPCIACCESS
>  	depends on BR2_i386 || BR2_x86_64
> @@ -22,22 +22,18 @@ config BR2_PACKAGE_LIBDRM_INTEL
>  
>  config BR2_PACKAGE_LIBDRM_RADEON
>  	bool "radeon"
> -	select BR2_PACKAGE_LIBATOMIC_OPS
> -	select BR2_PACKAGE_XLIB_LIBPCIACCESS
>  	depends on BR2_i386 || BR2_x86_64
>  	help
>  	  install AMD/ATI graphics driver
>  
>  config BR2_PACKAGE_LIBDRM_NOUVEAU
>  	bool "nouveau"
> -	select BR2_PACKAGE_XLIB_LIBPCIACCESS
>  	depends on BR2_i386 || BR2_x86_64
>  	help
>  	  install Nvidia graphics driver
>  
>  config BR2_PACKAGE_LIBDRM_VMWGFX
>  	bool "vmwgfx"
> -	select BR2_PACKAGE_XLIB_LIBPCIACCESS
>  	depends on BR2_i386 || BR2_x86_64
>  	help
>  	  installs Vmware graphics driver
> @@ -65,5 +61,4 @@ endmenu
>  endif
>  
>  comment "libdrm needs a toolchain w/ largefile"
> -	depends on BR2_PACKAGE_XORG7
>  	depends on !BR2_LARGEFILE
> diff --git a/package/libdrm/libdrm.mk b/package/libdrm/libdrm.mk
> index dd08af1..cecb382 100644
> --- a/package/libdrm/libdrm.mk
> +++ b/package/libdrm/libdrm.mk
> @@ -28,21 +28,18 @@ endif
>  
>  ifeq ($(BR2_PACKAGE_LIBDRM_RADEON),y)
>  LIBDRM_CONF_OPT += --enable-radeon
> -LIBDRM_DEPENDENCIES += xlib_libpciaccess
>  else
>  LIBDRM_CONF_OPT += --disable-radeon
>  endif
>  
>  ifeq ($(BR2_PACKAGE_LIBDRM_NOUVEAU),y)
>  LIBDRM_CONF_OPT += --enable-nouveau
> -LIBDRM_DEPENDENCIES += xlib_libpciaccess
>  else
>  LIBDRM_CONF_OPT += --disable-nouveau
>  endif
>  
>  ifeq ($(BR2_PACKAGE_LIBDRM_VMWGFX),y)
>  LIBDRM_CONF_OPT += --enable-vmwgfx
> -LIBDRM_DEPENDENCIES += xlib_libpciaccess
>  else
>  LIBDRM_CONF_OPT += --disable-vmwgfx
>  endif
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F