[Buildroot] [PATCH V4 2/2] i.MX: Update versions to match latest Freescale release

From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH V4 2/2] i.MX: Update versions to match latest Freescale release
Date: Wed, 12 Feb 2014 22:58:17 +0100	[thread overview]
Message-ID: <52FBEE79.9070901@mind.be> (raw)
In-Reply-To: <52FBD772.40900@boundarydevices.com>

On 12/02/14 21:20, Eric Nelson wrote:
> Hello Yann,
> 
> On 02/12/2014 12:10 PM, Eric Nelson wrote:
>> Hi Yann,
>>
>> On 02/12/2014 12:03 PM, Yann E. MORIN wrote:
>>> Eric, All,
>>>
>>> A (hopefully!) better review this time...
>>>
>>> On 2013-10-08 20:05 -0700, Eric Nelson spake thusly:
>>>> Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
>>>>
>>>> [--SNIP--]
>>>>
>>>> +# The archive is a shell-self-extractor of a bzipped tar. It happens
>>>> +# to extract in the correct directory (imx-lib-x.y.z)
>>>> +# The --force makes sure it doesn't fail if the source dir already
>>>> exists.
>>>> +# The --auto-accept skips the license check - not needed for us
>>>> +# because we have legal-info
>>>> +# Since there's a EULA in the bin file, extract it to
>>>> imx-lib-x.y.z/EULA
>>>> +#
>>>> +define IMX_LIB_EXTRACT_CMDS
>>>> +    awk 'BEGIN      { start=0; } \
>>>> +         /^EOEULA/  { start = 0; } \
>>>> +                    { if (start) print; } \
>>>> +         /<<EOEULA/ { start=1; }'\
>>>> +        $(DL_DIR)/$(IMX_LIB_SOURCE) > $(@D)/EULA
>>>> +    cd $(BUILD_DIR); \
>>>> +    sh $(DL_DIR)/$(IMX_LIB_SOURCE) --force --auto-accept
>>>> +endef
>>>
>>>      $ make imx-lib-extract
>>>      [...]
>>>      Unpacking file mkdir: cannot create directory ?imx-lib-3.5.7-1.0.0?:
>>>      File exists
>>>
>>> This is only a warning, but still: maybe extract the EULA _after_
>>> unpacking the archive?
>>>
>>
>> Sure. I'll re-work.
>>
> 
> Re-arranging these commands doesn't get rid of the warning.
> 
> It appears that the directory is created by the bit of
> structure using IMX_LIB_EXTRACT_CMDS, and the warning
> message is from a 'mkdir' embedded within the self-extracting
> package.
> 
> I could 'rm' the directory inside IMX_LIB_EXTRACT_CMDS,
> but it's not clear that this is the right thing to do.

 The directory exists already because the buildroot infrastructure
creates some stamp files in it - e.g. .stamp-downloaded. So if you'd
remove the directory, the download will be retried...

 Therefore, I think we should just live with the warning.

 Regards,
 Arnout

> 
> Please let me know your thoughts on the matter.
> 
> Regards,
> 
> 
> Eric
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F