Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Cédric Chépied" <cedric.chepied@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] ZNC: new package
Date: Sun, 05 Jan 2014 12:57:20 +0100	[thread overview]
Message-ID: <52c948a2.e358c20a.0e98.1fdc@mx.google.com> (raw)
In-Reply-To: <877gae7nd8.fsf@dell.be.48ers.dk>

At Sun, 05 Jan 2014 11:07:47 +0100,
Peter Korsgaard wrote:
> 
> >>>>> "C?dric" == C?dric Ch?pied <cedric.chepied@gmail.com> writes:
>  > diff --git a/package/znc/znc.mk b/package/znc/znc.mk
>  > new file mode 100644
>  > index 0000000..59d10f2
>  > --- /dev/null
>  > +++ b/package/znc/znc.mk
>  > @@ -0,0 +1,22 @@
>  > +ZNC_VERSION = 1.2
>  > +ZNC_SOURCE = znc-$(ZNC_VERSION).tar.gz
>  > +ZNC_SITE = http://znc.in/releases
>  > +ACL_INSTALL_STAGING = YES
> 
> Why does it need to install into staging? It's a program and not a
> library, right?

It does not. This is a bad copy/paste. I made this patch too quickly. 

> 
> 
>  > +
>  > +# While the configuration system uses autoconf, the Makefiles are
>  > +# hand-written and do not use automake. Therefore, we have to hack
>  > +# around their deficiencies by passing installation paths.
>  > +ACL_INSTALL_STAGING_OPT = 			\
>  > +	prefix=$(STAGING_DIR)/usr 		\
>  > +	exec_prefix=$(STAGING_DIR)/usr 		\
>  > +	PKG_DEVLIB_DIR=$(STAGING_DIR)/usr/lib	\
>  > +	install-dev install-lib
>  > +
>  > +ACL_INSTALL_TARGET_OPT = 			\
>  > +	prefix=$(TARGET_DIR)/usr 		\
>  > +	exec_prefix=$(TARGET_DIR)/usr 		\
>  > +	install install-lib
> 
> Out of interest, what does PKG_DEVLIB_DIR do and why don't we pass it
> for TARGET?


Same remark, I'll fix it and submit a new patch.

Regards,

-- 
C?dric Ch?pied
<cedric.chepied@gmail.com>

  reply	other threads:[~2014-01-05 11:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-04 22:59 [Buildroot] [PATCH] ZNC: new package Cédric Chépied
2014-01-05 10:07 ` Peter Korsgaard
2014-01-05 11:57   ` Cédric Chépied [this message]
2014-03-07 22:54     ` Thomas Petazzoni
2014-01-28 18:52 ` Thomas Petazzoni
2014-02-09 13:39   ` Cédric Chépied
  -- strict thread matches above, loose matches on Subject: below --
2014-01-01 21:53 Cédric Chépied
2014-01-02  8:59 ` Thomas Petazzoni
     [not found]   ` <52c542ae.87ad0e0a.3820.6636@mx.google.com>
2014-01-02 12:17     ` Thomas Petazzoni
2014-01-02  9:06 ` Jeremy Rosen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52c948a2.e358c20a.0e98.1fdc@mx.google.com \
    --to=cedric.chepied@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox