From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnout Vandecappelle Date: Mon, 17 Feb 2014 23:45:08 +0100 Subject: [Buildroot] [PATCH 04/10] toolchain/external: add choice to select 'AT_LEAST_XXX' header version In-Reply-To: <8fdcf8b3-c275-4250-be9c-11bcf4feaa11@email.android.com> References: <74d76e7816e2de0eccb9a24acd0b768c22078dfa.1392571021.git.yann.morin.1998@free.fr> <8fdcf8b3-c275-4250-be9c-11bcf4feaa11@email.android.com> Message-ID: <530290F4.1060507@mind.be> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net On 16/02/14 21:08, Thomas De Schampheleire wrote: > "Yann E. MORIN" schreef: >> From: "Yann E. MORIN" >> >> Select the appropriate BR2_TOOLCHAIN_HEADERS_AT_LEAST_XXX options for the >> external, custom toolchain backend. >> >> We try to be conservative here, and default to kernel headers 2.6.x. >> >> Signed-off-by: "Yann E. MORIN" >> Cc: Thomas Petazzoni >> Cc: Arnout Vandecappelle >> Cc: Thomas De Schampheleire >> --- >> toolchain/toolchain-external/Config-headers.in | 65 ++++++++++++++++++++++++++ >> toolchain/toolchain-external/Config.in | 2 + >> 2 files changed, 67 insertions(+) >> create mode 100644 toolchain/toolchain-external/Config-headers.in >> >> diff --git a/toolchain/toolchain-external/Config-headers.in b/toolchain/toolchain-external/Config-headers.in >> new file mode 100644 >> index 0000000..60ac384 >> --- /dev/null >> +++ b/toolchain/toolchain-external/Config-headers.in >> @@ -0,0 +1,65 @@ >> +choice >> + bool "External toolchain kernel headers" >> + depends on BR2_TOOLCHAIN_EXTERNAL_CUSTOM >> + default BR2_TOOLCHAIN_EXTERNAL_HEADERS_REALLY_OLD >> + > > Shouldn't there be a help text explaining what this is used for, so as to remove confusion about the fact that the kernel header version was already chosen when the toolchain was built? Note, however, that you can't add help text to a choice. So the only option is to add the text to every choice option. Ah, the limitations of Kconfig... Regards, Arnout > > Best regards, > Thomas > > -- Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F