From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4 7/7] Makefile: export PATH
Date: Tue, 18 Feb 2014 07:32:48 +0100 [thread overview]
Message-ID: <5302FE90.9070402@mind.be> (raw)
In-Reply-To: <1392559113-5215-8-git-send-email-s.martin49@gmail.com>
On 16/02/14 14:58, Samuel Martin wrote:
> This can be useful for:
> - package using custom build system that are not aware that the host
> tree is in $(O)/host/;
> - post-{build,image} scripts, in case some host-tools were specifically
> built to be used by these scripts.
This makes all the previous patches redundant, since the PATH=...
invocations should be removed instead of renamed.
>
> Signed-off-by: Samuel Martin <s.martin49@gmail.com>
>
> ---
> changes v3 -> v4:
> - rebase
> - rename BR2_PATH -> BR_PATH
>
> changes v2 -> v3:
> - rebase
> - extend commit loghanges v2 -> v3:
>
> changes v1 -> v2:
> - extend commit message
> ---
> Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Makefile b/Makefile
> index bb5b38e..ca2d721 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -353,6 +353,7 @@ export STAGING_DIR
> export HOST_DIR
> export BINARIES_DIR
> export BASE_DIR
> +export PATH:=$(BR_PATH)
With this change, the := in BR_PATH becomes essential. There should be a
comment there to explain why. Also, the assignment to BR_PATH and to PATH
should be right next to each other (the export can stay here, though).
And in fact, BR_PATH becomes completely redundant, it's sufficient to
have a single PATH := ....:$(PATH)
Regards,
Arnout
>
> ################################################################################
> #
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
next prev parent reply other threads:[~2014-02-18 6:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-16 13:58 [Buildroot] [PATCH v4 0/7] PATH cleanup Samuel Martin
2014-02-16 13:58 ` [Buildroot] [PATCH v4 1/7] bustle: use TARGET_MAKE_ENV instead of setting PATH in the make environment Samuel Martin
2014-02-18 15:35 ` Thomas Petazzoni
2014-02-16 13:58 ` [Buildroot] [PATCH v4 2/7] Makefile: introduce BR_PATH Samuel Martin
2014-02-18 6:25 ` Arnout Vandecappelle
2014-02-16 13:58 ` [Buildroot] [PATCH v4 3/7] Makefile: add $(HOST_DIR)/sbin to BR_PATH Samuel Martin
2014-02-16 13:58 ` [Buildroot] [PATCH v4 4/7] *.mk: replace (TARGET|HOST)_PATH by BR_PATH Samuel Martin
2014-02-18 6:28 ` Arnout Vandecappelle
2014-02-16 13:58 ` [Buildroot] [PATCH v4 5/7] infra: remove unused {TARGET, HOST}_PATH definition Samuel Martin
2014-02-16 13:58 ` [Buildroot] [PATCH v4 6/7] pkg-cmake.mk: add PATH in the configure command environment Samuel Martin
2014-02-16 13:58 ` [Buildroot] [PATCH v4 7/7] Makefile: export PATH Samuel Martin
2014-02-18 6:32 ` Arnout Vandecappelle [this message]
2014-02-18 15:37 ` Thomas Petazzoni
2014-02-18 15:55 ` Samuel Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5302FE90.9070402@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox