From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnout Vandecappelle Date: Thu, 20 Feb 2014 10:55:50 +0100 Subject: [Buildroot] [PATCH] webkit: disable on < ARMv5t In-Reply-To: <20140220090555.42dc8d0d@skate> References: <1392847730-14412-1-git-send-email-thomas.petazzoni@free-electrons.com> <53059EBE.6030902@mind.be> <20140220090555.42dc8d0d@skate> Message-ID: <5305D126.6050109@mind.be> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net On 20/02/14 09:05, Thomas Petazzoni wrote: > Dear Arnout Vandecappelle, > > On Thu, 20 Feb 2014 07:20:46 +0100, Arnout Vandecappelle wrote: > >>> diff --git a/package/webkit/Config.in b/package/webkit/Config.in >>> index 0207a6d..daaec36 100644 >>> --- a/package/webkit/Config.in >>> +++ b/package/webkit/Config.in >>> @@ -1,11 +1,18 @@ >>> +config BR2_PACKAGE_WEBKIT_ARCH_SUPPORTS >>> + bool >>> + # ARM needs BLX, so v5t+ >>> + default y if (BR2_arm || BR2_armeb) && \ >>> + !(BR2_arm7tdmi || BR2_arm720t || BR2_arm920t || BR2_arm922t || BR2_fa526) >>> + default y if BR2_i386 || BR2_mips || BR2_mipsel || \ >>> + BR2_powerpc || BR2_sh || BR2_sparc || BR2_x86_64 >> >> We normally write >> >> depends on FOO >> depends on BAR >> >> rather than >> >> depends on FOO && BAR >> >> Shouldn't we do the same here? >> >> default y if BR2_i386 >> default y if BR2_mips > > Are you talking about the first line (about ARM), or the second line > (for all the other architectures) ? For all the other architectures. That's why it says BR2_i386 and not BR2_arm :-) For BR2_arm it is not possible because you have an &&. Well, you could put BR2_arm and BR2_armeb on separate lines but then you have to repeat all the exclusions - not so nice. Regards, Arnout > > Thomas > -- Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F