From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vicente Olivert Riera Date: Mon, 24 Feb 2014 09:50:29 +0000 Subject: [Buildroot] [git commit] rt-tests: fix mips+uclibc check In-Reply-To: <20140223175404.BAA579B92A@busybox.osuosl.org> References: <20140223175404.BAA579B92A@busybox.osuosl.org> Message-ID: <530B15E5.5080706@imgtec.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net On 02/23/2014 05:52 PM, Peter Korsgaard wrote: > commit: http://git.buildroot.net/buildroot/commit/?id=088ed8dcbb061bf573a0ed5c98fff22bac6138c0 > branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master > > The conditional (suggested by me) introduced in 108952 (rt-tests: disable > for uclibc mips) isn't actually valid kconfig syntax, causing menuconfig to > error out. > > Rewrite it to use proper syntax. > > Signed-off-by: Peter Korsgaard > --- > package/rt-tests/Config.in | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/package/rt-tests/Config.in b/package/rt-tests/Config.in > index ff4284e..8940668 100644 > --- a/package/rt-tests/Config.in > +++ b/package/rt-tests/Config.in > @@ -6,8 +6,8 @@ config BR2_PACKAGE_RT_TESTS > # no NPTL for these archs > depends on !BR2_avr32 && !BR2_xtensa && !BR2_arc && !BR2_bfin > # no _tid field in 'struct sigevent' > - depends on !BR2_TOOLCHAIN_USES_UCLIBC if (BR2_mips || BR2_mipsel || \ > - BR2_mips64 || BR2_mips64el) > + depends on !(BR2_TOOLCHAIN_USES_UCLIBC && (BR2_mips || BR2_mipsel || \ > + BR2_mips64 || BR2_mips64el)) > help > Set of utilities for testing the real-time behaviour of a > Linux system. > @@ -32,5 +32,5 @@ comment "rt-tests needs a toolchain w/ threads" > depends on !BR2_TOOLCHAIN_HAS_THREADS > > comment "rt-tests needs an (e)glibc toolchain" > - depends on BR2_TOOLCHAIN_USES_UCLIBC if (BR2_mips || BR2_mipsel || \ > + depends on BR2_TOOLCHAIN_USES_UCLIBC && (BR2_mips || BR2_mipsel || \ > BR2_mips64 || BR2_mips64el) > _______________________________________________ > buildroot mailing list > buildroot at busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot > If I recall correctly, when I was investigating this failure before submitting the fix to uClibc upstream, there were more architectures with this problem. MIPS wasn't the only one. Has that been changed? -- Vincent