From: Jerzy Grzegorek <jerzy.grzegorek@trzebnica.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 04/19] package/libopenvg: rename the _HAS and _PROVIDES variables
Date: Sun, 02 Mar 2014 23:39:12 +0100 [thread overview]
Message-ID: <5313B310.9080304@trzebnica.net> (raw)
In-Reply-To: <2f963768990b1c955d044e5f5d587f39e110bf01.1393778339.git.yann.morin.1998@free.fr>
Hi Yann,
> From: "Yann E. MORIN" <yann.morin.1998@free.fr>
>
> The basic rule for a package is to have its options named
> after the package name. There is no reason this should not
> also be the case for virtual packages.
>
> Besides, this will allow us to switch libopenvg to use the
> soo-to-be-introduced virtual-package infrastructure.
soon-to-be-introduced
Regards,
Jerzy
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Eric Le Bihan <eric.le.bihan.dev@free.fr>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Cc: Thomas De Schampheleire <patrickdepinguin@gmail.com>
> Cc: Mike Zick <minimod@morethan.org>
> Reviewed-by: Samuel Martin <s.martin49@gmail.com>
> ---
> package/cairo/cairo.mk | 2 +-
> package/opengl/libopenvg/Config.in | 6 +++---
> package/opengl/libopenvg/libopenvg.mk | 4 ++--
> package/rpi-userland/Config.in | 4 ++--
> 4 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/package/cairo/cairo.mk b/package/cairo/cairo.mk
> index ddd57db..c566d4a 100644
> --- a/package/cairo/cairo.mk
> +++ b/package/cairo/cairo.mk
> @@ -61,7 +61,7 @@ else
> CAIRO_CONF_OPT += --disable-glesv2
> endif
>
> -ifeq ($(BR2_PACKAGE_HAS_OPENVG),y)
> +ifeq ($(BR2_PACKAGE_HAS_LIBOPENVG),y)
> CAIRO_CONF_OPT += --enable-vg
> CAIRO_DEPENDENCIES += libopenvg
> else
> diff --git a/package/opengl/libopenvg/Config.in b/package/opengl/libopenvg/Config.in
> index 9d31525..53cde6a 100644
> --- a/package/opengl/libopenvg/Config.in
> +++ b/package/opengl/libopenvg/Config.in
> @@ -1,6 +1,6 @@
> -config BR2_PACKAGE_HAS_OPENVG
> +config BR2_PACKAGE_HAS_LIBOPENVG
> bool
>
> -config BR2_PACKAGE_PROVIDES_OPENVG
> - depends on BR2_PACKAGE_HAS_OPENVG
> +config BR2_PACKAGE_PROVIDES_LIBOPENVG
> + depends on BR2_PACKAGE_HAS_LIBOPENVG
> string
> diff --git a/package/opengl/libopenvg/libopenvg.mk b/package/opengl/libopenvg/libopenvg.mk
> index f81db5e..1c6f929 100644
> --- a/package/opengl/libopenvg/libopenvg.mk
> +++ b/package/opengl/libopenvg/libopenvg.mk
> @@ -5,9 +5,9 @@
> ################################################################################
>
> LIBOPENVG_SOURCE =
> -LIBOPENVG_DEPENDENCIES = $(call qstrip,$(BR2_PACKAGE_PROVIDES_OPENVG))
> +LIBOPENVG_DEPENDENCIES = $(call qstrip,$(BR2_PACKAGE_PROVIDES_LIBOPENVG))
>
> -ifeq ($(BR2_PACKAGE_HAS_OPENVG),y)
> +ifeq ($(BR2_PACKAGE_HAS_LIBOPENVG),y)
> ifeq ($(LIBOPENVG_DEPENDENCIES),)
> $(error No libOpenVG implementation selected. Configuration error.)
> endif
> diff --git a/package/rpi-userland/Config.in b/package/rpi-userland/Config.in
> index 7238092..76ea718 100644
> --- a/package/rpi-userland/Config.in
> +++ b/package/rpi-userland/Config.in
> @@ -6,7 +6,7 @@ config BR2_PACKAGE_RPI_USERLAND
> depends on BR2_TOOLCHAIN_HAS_THREADS
> select BR2_PACKAGE_HAS_OPENGL_LIBEGL
> select BR2_PACKAGE_HAS_OPENGL_LIBGLES
> - select BR2_PACKAGE_HAS_OPENVG
> + select BR2_PACKAGE_HAS_LIBOPENVG
> select BR2_PACKAGE_HAS_LIBOPENMAX
> help
> Raspberry Pi Userland contains the necessary library to use the
> @@ -25,7 +25,7 @@ config BR2_PACKAGE_PROVIDES_OPENGL_LIBEGL
> config BR2_PACKAGE_PROVIDES_OPENGL_LIBGLES
> default "rpi-userland"
>
> -config BR2_PACKAGE_PROVIDES_OPENVG
> +config BR2_PACKAGE_PROVIDES_LIBOPENVG
> default "rpi-userland"
>
> config BR2_PACKAGE_PROVIDES_LIBOPENMAX
next prev parent reply other threads:[~2014-03-02 22:39 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-02 16:52 [Buildroot] [PATCH 0/19 v3] Add new virtual-package infrastructure Yann E. MORIN
2014-03-02 16:52 ` [Buildroot] [PATCH 01/19] package/libgles: rename package and the _HAS and _PROVIDES variables Yann E. MORIN
2014-03-02 17:26 ` Samuel Martin
2014-03-02 16:52 ` [Buildroot] [PATCH 02/19] package/libegl: " Yann E. MORIN
2014-03-02 17:27 ` Samuel Martin
2014-03-02 16:52 ` [Buildroot] [PATCH 03/19] package/libopenmax: rename " Yann E. MORIN
2014-03-02 16:52 ` [Buildroot] [PATCH 04/19] package/libopenvg: " Yann E. MORIN
2014-03-02 22:39 ` Jerzy Grzegorek [this message]
2014-03-02 16:52 ` [Buildroot] [PATCH 05/19] package/luainterpreter: " Yann E. MORIN
2014-03-02 16:52 ` [Buildroot] [PATCH 06/19] package/lua: rename config options Yann E. MORIN
2014-03-02 16:52 ` [Buildroot] [PATCH 07/19] manual: add virtual package tutorial Yann E. MORIN
2014-03-02 16:52 ` [Buildroot] [PATCH 08/19] packages: add infrastructure for virtual packages Yann E. MORIN
2014-03-02 16:52 ` [Buildroot] [PATCH 09/19] manual: update the virtual package section with the new infrastructure Yann E. MORIN
2014-03-02 16:52 ` [Buildroot] [PATCH 10/19] package/powervr: convert to the virtual-package infrastructure Yann E. MORIN
2014-03-02 16:52 ` [Buildroot] [PATCH 11/19] package/opengl-libgles: " Yann E. MORIN
2014-03-02 16:52 ` [Buildroot] [PATCH 12/19] package/opengl-libegl: " Yann E. MORIN
2014-03-02 16:52 ` [Buildroot] [PATCH 13/19] package/libopenmax: " Yann E. MORIN
2014-03-02 16:52 ` [Buildroot] [PATCH 14/19] package/libopenvg: " Yann E. MORIN
2014-03-02 16:52 ` [Buildroot] [PATCH 15/19] package/luainterpreter: " Yann E. MORIN
2014-03-02 16:52 ` [Buildroot] [PATCH 16/19] package/jpeg: " Yann E. MORIN
2014-03-02 16:52 ` [Buildroot] [PATCH 17/19] package/cryptodev: " Yann E. MORIN
2014-03-02 16:52 ` [Buildroot] [PATCH 18/19] virtual-package: fake a version string for virtual packages Yann E. MORIN
2014-03-02 17:29 ` Samuel Martin
2014-03-02 16:53 ` [Buildroot] [PATCH 19/19] FOO: tentative target and host virt packages Yann E. MORIN
2014-03-03 17:19 ` [Buildroot] [PATCH 0/19 v3] Add new virtual-package infrastructure Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5313B310.9080304@trzebnica.net \
--to=jerzy.grzegorek@trzebnica.net \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox