* [Buildroot] [PATCH] toolchain/wrapper: rename BR_DEBUG_WRAPPER
@ 2014-03-03 22:55 Yann E. MORIN
2014-03-05 7:12 ` Arnout Vandecappelle
2014-03-05 18:46 ` Thomas Petazzoni
0 siblings, 2 replies; 3+ messages in thread
From: Yann E. MORIN @ 2014-03-03 22:55 UTC (permalink / raw)
To: buildroot
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
The user-facing variables should be prefixed with BR2_, not BR_.
Also quote the variable in the manual.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
docs/manual/customize-toolchain.txt | 2 +-
toolchain/toolchain-external/ext-toolchain-wrapper.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/docs/manual/customize-toolchain.txt b/docs/manual/customize-toolchain.txt
index 4f3fe23..55a0480 100644
--- a/docs/manual/customize-toolchain.txt
+++ b/docs/manual/customize-toolchain.txt
@@ -21,7 +21,7 @@ When using an external toolchain, Buildroot generates a wrapper program,
that transparently passes the appropriate options (according to the
configuration) to the external toolchain programs. In case you need to
debug this wrapper to check exactly what arguments are passed, you can
-set the environment variable BR_DEBUG_WRAPPER to either one of:
+set the environment variable +BR2_DEBUG_WRAPPER+ to either one of:
* +0+, empty or not set: no debug
diff --git a/toolchain/toolchain-external/ext-toolchain-wrapper.c b/toolchain/toolchain-external/ext-toolchain-wrapper.c
index 81c6ed1..db49784 100644
--- a/toolchain/toolchain-external/ext-toolchain-wrapper.c
+++ b/toolchain/toolchain-external/ext-toolchain-wrapper.c
@@ -191,7 +191,7 @@ int main(int argc, char **argv)
* set to 1 : trace all arguments on a single line
* set to 2 : trace one argument per line
*/
- if ((env_debug = getenv("BR_DEBUG_WRAPPER"))) {
+ if ((env_debug = getenv("BR2_DEBUG_WRAPPER"))) {
debug = atoi(env_debug);
if (debug > 0) {
fprintf(stderr, "Toolchain wrapper executing:");
--
1.8.3.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] toolchain/wrapper: rename BR_DEBUG_WRAPPER
2014-03-03 22:55 [Buildroot] [PATCH] toolchain/wrapper: rename BR_DEBUG_WRAPPER Yann E. MORIN
@ 2014-03-05 7:12 ` Arnout Vandecappelle
2014-03-05 18:46 ` Thomas Petazzoni
1 sibling, 0 replies; 3+ messages in thread
From: Arnout Vandecappelle @ 2014-03-05 7:12 UTC (permalink / raw)
To: buildroot
On 03/03/14 23:55, Yann E. MORIN wrote:
> From: "Yann E. MORIN" <yann.morin.1998@free.fr>
>
> The user-facing variables should be prefixed with BR2_, not BR_.
>
> Also quote the variable in the manual.
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Regards,
Arnout
> ---
> docs/manual/customize-toolchain.txt | 2 +-
> toolchain/toolchain-external/ext-toolchain-wrapper.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/docs/manual/customize-toolchain.txt b/docs/manual/customize-toolchain.txt
> index 4f3fe23..55a0480 100644
> --- a/docs/manual/customize-toolchain.txt
> +++ b/docs/manual/customize-toolchain.txt
> @@ -21,7 +21,7 @@ When using an external toolchain, Buildroot generates a wrapper program,
> that transparently passes the appropriate options (according to the
> configuration) to the external toolchain programs. In case you need to
> debug this wrapper to check exactly what arguments are passed, you can
> -set the environment variable BR_DEBUG_WRAPPER to either one of:
> +set the environment variable +BR2_DEBUG_WRAPPER+ to either one of:
>
> * +0+, empty or not set: no debug
>
> diff --git a/toolchain/toolchain-external/ext-toolchain-wrapper.c b/toolchain/toolchain-external/ext-toolchain-wrapper.c
> index 81c6ed1..db49784 100644
> --- a/toolchain/toolchain-external/ext-toolchain-wrapper.c
> +++ b/toolchain/toolchain-external/ext-toolchain-wrapper.c
> @@ -191,7 +191,7 @@ int main(int argc, char **argv)
> * set to 1 : trace all arguments on a single line
> * set to 2 : trace one argument per line
> */
> - if ((env_debug = getenv("BR_DEBUG_WRAPPER"))) {
> + if ((env_debug = getenv("BR2_DEBUG_WRAPPER"))) {
> debug = atoi(env_debug);
> if (debug > 0) {
> fprintf(stderr, "Toolchain wrapper executing:");
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] toolchain/wrapper: rename BR_DEBUG_WRAPPER
2014-03-03 22:55 [Buildroot] [PATCH] toolchain/wrapper: rename BR_DEBUG_WRAPPER Yann E. MORIN
2014-03-05 7:12 ` Arnout Vandecappelle
@ 2014-03-05 18:46 ` Thomas Petazzoni
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2014-03-05 18:46 UTC (permalink / raw)
To: buildroot
Dear Yann E. MORIN,
On Mon, 3 Mar 2014 23:55:05 +0100, Yann E. MORIN wrote:
> From: "Yann E. MORIN" <yann.morin.1998@free.fr>
>
> The user-facing variables should be prefixed with BR2_, not BR_.
>
> Also quote the variable in the manual.
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
> docs/manual/customize-toolchain.txt | 2 +-
> toolchain/toolchain-external/ext-toolchain-wrapper.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
Applied, thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-03-05 18:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-03 22:55 [Buildroot] [PATCH] toolchain/wrapper: rename BR_DEBUG_WRAPPER Yann E. MORIN
2014-03-05 7:12 ` Arnout Vandecappelle
2014-03-05 18:46 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).