From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Disable o32 ABI for MIPS64 architectures
Date: Thu, 06 Mar 2014 00:27:40 +0100 [thread overview]
Message-ID: <5317B2EC.4010201@mind.be> (raw)
In-Reply-To: <1394039187-24328-1-git-send-email-Vincent.Riera@imgtec.com>
On 05/03/14 18:06, Vicente Olivert Riera wrote:
> Building o32 ELF files for MIPS64 is an exotic configuration that nobody
> should be using. If o32 is required, then is better if it's built for
> MIPS 32-bit cores so only 32-bit instructions will be used leading to a
> more efficient o32 usage.
>
> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> ---
> arch/Config.in.mips | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/Config.in.mips b/arch/Config.in.mips
> index d9c0c02..e2b1e60 100644
> --- a/arch/Config.in.mips
> +++ b/arch/Config.in.mips
> @@ -47,6 +47,7 @@ choice
>
> config BR2_MIPS_OABI32
> bool "o32"
> + depends on !BR2_ARCH_IS_64
> config BR2_MIPS_NABI32
> bool "n32"
> depends on BR2_ARCH_IS_64
>
Then maybe it's better to make the choice depend on BR2_ARCH_IS_64, and
make the OABI32 symbol blind and default y on !BR2_ARCH_IS_64.
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
next prev parent reply other threads:[~2014-03-05 23:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-05 17:06 [Buildroot] [PATCH] Disable o32 ABI for MIPS64 architectures Vicente Olivert Riera
2014-03-05 23:27 ` Arnout Vandecappelle [this message]
2014-03-06 9:51 ` Vicente Olivert Riera
2014-03-06 11:13 ` Arnout Vandecappelle
2014-03-25 17:54 ` Vicente Olivert Riera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5317B2EC.4010201@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).