* [Buildroot] [PATCH] Disable o32 ABI for MIPS64 architectures
@ 2014-03-05 17:06 Vicente Olivert Riera
2014-03-05 23:27 ` Arnout Vandecappelle
0 siblings, 1 reply; 5+ messages in thread
From: Vicente Olivert Riera @ 2014-03-05 17:06 UTC (permalink / raw)
To: buildroot
Building o32 ELF files for MIPS64 is an exotic configuration that nobody
should be using. If o32 is required, then is better if it's built for
MIPS 32-bit cores so only 32-bit instructions will be used leading to a
more efficient o32 usage.
Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
---
arch/Config.in.mips | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/Config.in.mips b/arch/Config.in.mips
index d9c0c02..e2b1e60 100644
--- a/arch/Config.in.mips
+++ b/arch/Config.in.mips
@@ -47,6 +47,7 @@ choice
config BR2_MIPS_OABI32
bool "o32"
+ depends on !BR2_ARCH_IS_64
config BR2_MIPS_NABI32
bool "n32"
depends on BR2_ARCH_IS_64
--
1.7.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] Disable o32 ABI for MIPS64 architectures
2014-03-05 17:06 [Buildroot] [PATCH] Disable o32 ABI for MIPS64 architectures Vicente Olivert Riera
@ 2014-03-05 23:27 ` Arnout Vandecappelle
2014-03-06 9:51 ` Vicente Olivert Riera
0 siblings, 1 reply; 5+ messages in thread
From: Arnout Vandecappelle @ 2014-03-05 23:27 UTC (permalink / raw)
To: buildroot
On 05/03/14 18:06, Vicente Olivert Riera wrote:
> Building o32 ELF files for MIPS64 is an exotic configuration that nobody
> should be using. If o32 is required, then is better if it's built for
> MIPS 32-bit cores so only 32-bit instructions will be used leading to a
> more efficient o32 usage.
>
> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> ---
> arch/Config.in.mips | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/Config.in.mips b/arch/Config.in.mips
> index d9c0c02..e2b1e60 100644
> --- a/arch/Config.in.mips
> +++ b/arch/Config.in.mips
> @@ -47,6 +47,7 @@ choice
>
> config BR2_MIPS_OABI32
> bool "o32"
> + depends on !BR2_ARCH_IS_64
> config BR2_MIPS_NABI32
> bool "n32"
> depends on BR2_ARCH_IS_64
>
Then maybe it's better to make the choice depend on BR2_ARCH_IS_64, and
make the OABI32 symbol blind and default y on !BR2_ARCH_IS_64.
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] Disable o32 ABI for MIPS64 architectures
2014-03-05 23:27 ` Arnout Vandecappelle
@ 2014-03-06 9:51 ` Vicente Olivert Riera
2014-03-06 11:13 ` Arnout Vandecappelle
0 siblings, 1 reply; 5+ messages in thread
From: Vicente Olivert Riera @ 2014-03-06 9:51 UTC (permalink / raw)
To: buildroot
On 03/05/2014 11:27 PM, Arnout Vandecappelle wrote:
> On 05/03/14 18:06, Vicente Olivert Riera wrote:
>> Building o32 ELF files for MIPS64 is an exotic configuration that nobody
>> should be using. If o32 is required, then is better if it's built for
>> MIPS 32-bit cores so only 32-bit instructions will be used leading to a
>> more efficient o32 usage.
>>
>> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
>> ---
>> arch/Config.in.mips | 1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/Config.in.mips b/arch/Config.in.mips
>> index d9c0c02..e2b1e60 100644
>> --- a/arch/Config.in.mips
>> +++ b/arch/Config.in.mips
>> @@ -47,6 +47,7 @@ choice
>>
>> config BR2_MIPS_OABI32
>> bool "o32"
>> + depends on !BR2_ARCH_IS_64
>> config BR2_MIPS_NABI32
>> bool "n32"
>> depends on BR2_ARCH_IS_64
>>
>
> Then maybe it's better to make the choice depend on BR2_ARCH_IS_64, and
> make the OABI32 symbol blind and default y on !BR2_ARCH_IS_64.
OABI32 is already the default on !BR2_ARCH_IS_64. Take a look to this
part of the Config.in.mips:
choice
prompt "Target ABI"
depends on BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el
default BR2_MIPS_OABI32 if !BR2_ARCH_IS_64
default BR2_MIPS_NABI32 if BR2_ARCH_IS_64
>
> Regards,
> Arnout
>
--
Vincent
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] Disable o32 ABI for MIPS64 architectures
2014-03-06 9:51 ` Vicente Olivert Riera
@ 2014-03-06 11:13 ` Arnout Vandecappelle
2014-03-25 17:54 ` Vicente Olivert Riera
0 siblings, 1 reply; 5+ messages in thread
From: Arnout Vandecappelle @ 2014-03-06 11:13 UTC (permalink / raw)
To: buildroot
On 06/03/14 10:51, Vicente Olivert Riera wrote:
> On 03/05/2014 11:27 PM, Arnout Vandecappelle wrote:
>> On 05/03/14 18:06, Vicente Olivert Riera wrote:
>>> Building o32 ELF files for MIPS64 is an exotic configuration that nobody
>>> should be using. If o32 is required, then is better if it's built for
>>> MIPS 32-bit cores so only 32-bit instructions will be used leading to a
>>> more efficient o32 usage.
>>>
>>> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
>>> ---
>>> arch/Config.in.mips | 1 +
>>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/arch/Config.in.mips b/arch/Config.in.mips
>>> index d9c0c02..e2b1e60 100644
>>> --- a/arch/Config.in.mips
>>> +++ b/arch/Config.in.mips
>>> @@ -47,6 +47,7 @@ choice
>>>
>>> config BR2_MIPS_OABI32
>>> bool "o32"
>>> + depends on !BR2_ARCH_IS_64
>>> config BR2_MIPS_NABI32
>>> bool "n32"
>>> depends on BR2_ARCH_IS_64
>>>
>>
>> Then maybe it's better to make the choice depend on BR2_ARCH_IS_64, and
>> make the OABI32 symbol blind and default y on !BR2_ARCH_IS_64.
>
> OABI32 is already the default on !BR2_ARCH_IS_64. Take a look to this
> part of the Config.in.mips:
>
> choice
> prompt "Target ABI"
> depends on BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el
> default BR2_MIPS_OABI32 if !BR2_ARCH_IS_64
> default BR2_MIPS_NABI32 if BR2_ARCH_IS_64
It's not just the default, it's the only valid choice. So indeed, it
already doesn't make much sense to present the user with the choice if
there is only one option. However, removing it is currently a bit
complicated because you need to keep the BR2_MIPS_OABI32 config in the
choice for BR2_ARCH_IS_64.
However, with your change, there is no need at all to keep the OABI32
option in the choice: if 64, it is forced to no, and if !64, it is forced
to yes.
BTW, something I forgot to mention earlier: ideally there should be a
legacy detection for existing configs with 64 and OABI32. It may be a bit
difficult to implement, however.
Regards,
Arnout
>
>>
>> Regards,
>> Arnout
>>
>
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] Disable o32 ABI for MIPS64 architectures
2014-03-06 11:13 ` Arnout Vandecappelle
@ 2014-03-25 17:54 ` Vicente Olivert Riera
0 siblings, 0 replies; 5+ messages in thread
From: Vicente Olivert Riera @ 2014-03-25 17:54 UTC (permalink / raw)
To: buildroot
On 03/06/2014 11:13 AM, Arnout Vandecappelle wrote:
> On 06/03/14 10:51, Vicente Olivert Riera wrote:
>> On 03/05/2014 11:27 PM, Arnout Vandecappelle wrote:
>>> On 05/03/14 18:06, Vicente Olivert Riera wrote:
>>>> Building o32 ELF files for MIPS64 is an exotic configuration that nobody
>>>> should be using. If o32 is required, then is better if it's built for
>>>> MIPS 32-bit cores so only 32-bit instructions will be used leading to a
>>>> more efficient o32 usage.
>>>>
>>>> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
>>>> ---
>>>> arch/Config.in.mips | 1 +
>>>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>>>
>>>> diff --git a/arch/Config.in.mips b/arch/Config.in.mips
>>>> index d9c0c02..e2b1e60 100644
>>>> --- a/arch/Config.in.mips
>>>> +++ b/arch/Config.in.mips
>>>> @@ -47,6 +47,7 @@ choice
>>>>
>>>> config BR2_MIPS_OABI32
>>>> bool "o32"
>>>> + depends on !BR2_ARCH_IS_64
>>>> config BR2_MIPS_NABI32
>>>> bool "n32"
>>>> depends on BR2_ARCH_IS_64
>>>>
>>>
>>> Then maybe it's better to make the choice depend on BR2_ARCH_IS_64, and
>>> make the OABI32 symbol blind and default y on !BR2_ARCH_IS_64.
>>
>> OABI32 is already the default on !BR2_ARCH_IS_64. Take a look to this
>> part of the Config.in.mips:
>>
>> choice
>> prompt "Target ABI"
>> depends on BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el
>> default BR2_MIPS_OABI32 if !BR2_ARCH_IS_64
>> default BR2_MIPS_NABI32 if BR2_ARCH_IS_64
>
> It's not just the default, it's the only valid choice. So indeed, it
> already doesn't make much sense to present the user with the choice if
> there is only one option. However, removing it is currently a bit
> complicated because you need to keep the BR2_MIPS_OABI32 config in the
> choice for BR2_ARCH_IS_64.
>
> However, with your change, there is no need at all to keep the OABI32
> option in the choice: if 64, it is forced to no, and if !64, it is forced
> to yes.
>
>
> BTW, something I forgot to mention earlier: ideally there should be a
> legacy detection for existing configs with 64 and OABI32. It may be a bit
> difficult to implement, however.
>
> Regards,
> Arnout
>
>
>>
>>>
>>> Regards,
>>> Arnout
>>>
>>
>>
>
>
Patch V2 sent: http://patchwork.ozlabs.org/patch/333638/
--
Vincent
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-03-25 17:54 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-05 17:06 [Buildroot] [PATCH] Disable o32 ABI for MIPS64 architectures Vicente Olivert Riera
2014-03-05 23:27 ` Arnout Vandecappelle
2014-03-06 9:51 ` Vicente Olivert Riera
2014-03-06 11:13 ` Arnout Vandecappelle
2014-03-25 17:54 ` Vicente Olivert Riera
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).