From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnout Vandecappelle Date: Tue, 25 Mar 2014 21:02:28 +0100 Subject: [Buildroot] [PATCH v2] Disable o32 ABI for MIPS64 architectures In-Reply-To: <1395769952-64221-1-git-send-email-Vincent.Riera@imgtec.com> References: <1395769952-64221-1-git-send-email-Vincent.Riera@imgtec.com> Message-ID: <5331E0D4.6070007@mind.be> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net On 25/03/14 18:52, Vicente Olivert Riera wrote: > Building o32 ELF files for MIPS64 is an exotic configuration that nobody > should be using. If o32 is required, then is better if it's built for > MIPS 32-bit cores so only 32-bit instructions will be used leading to a > more efficient o32 usage. > > Signed-off-by: Vicente Olivert Riera > --- > arch/Config.in.mips | 12 +++++++----- > 1 files changed, 7 insertions(+), 5 deletions(-) > > diff --git a/arch/Config.in.mips b/arch/Config.in.mips > index d9c0c02..f558705 100644 > --- a/arch/Config.in.mips > +++ b/arch/Config.in.mips > @@ -38,15 +38,12 @@ endchoice > > choice > prompt "Target ABI" > - depends on BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el > - default BR2_MIPS_OABI32 if !BR2_ARCH_IS_64 > - default BR2_MIPS_NABI32 if BR2_ARCH_IS_64 > + depends on BR2_mips64 || BR2_mips64el > + default BR2_MIPS_NABI32 > > help > Application Binary Interface to use > > -config BR2_MIPS_OABI32 > - bool "o32" > config BR2_MIPS_NABI32 > bool "n32" > depends on BR2_ARCH_IS_64 > @@ -86,6 +83,11 @@ config BR2_GCC_TARGET_ARCH > default "mips64" if BR2_mips_64 > default "mips64r2" if BR2_mips_64r2 > > +config BR2_MIPS_OABI32 > + bool > + default y if BR2_mips || BR2_mipsel > + default n if BR2_mips64 || BR2_mips64el The default n isn't needed - that is the default already in all other cases. > + > config BR2_GCC_TARGET_ABI > default "32" if BR2_MIPS_OABI32 > default "n32" if BR2_MIPS_NABI32 > Normally we should have a Config.in.legacy entry to catch old .configs that have o32 for a mips64 target. However, that is not possible now. Therefore, it should be captured in the release notes. To make sure that Peter doesn't forget, can you add this to the top of CHANGES? 2014.05, Not yet released: Support for MIPS o32 ABI on MIPS-64 targets has been removed. Building o32 ELF files for MIPS64 is an exotic configuration that nobody should be using. If o32 is required, then is better if it's built for MIPS 32-bit cores so only 32-bit instructions will be used leading to a more efficient o32 usage. Regards, Arnout -- Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F