From: Jerzy Grzegorek <jerzy.grzegorek@trzebnica.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 1/1] manual/configure.txt: fix typo
Date: Sat, 05 Apr 2014 10:14:52 +0200 [thread overview]
Message-ID: <533FBB7C.1020409@trzebnica.net> (raw)
In-Reply-To: <533E4A29.2070009@mind.be>
Hi Arnout,
Thanks for the feedback.
> On 03/04/14 23:21, Jerzy Grzegorek wrote:
>> Signed-off-by: Jerzy Grzegorek <jerzy.grzegorek@trzebnica.net>
> Could you add to the commit log _why_ this is a typo? You're removing a
> backslash in one place and adding it in another place, so it is not at
> all obvious why this is the correct thing to do. In fact, it's not a
> typo, it's a formatting error.
There is an extra backslash in the latest stable release buildroot 2014.02
documentation (html and pdf); have a look at:
http://buildroot.uclibc.org/downloads/manual/manual.html#_cross_compilation_toolchain
manual/configure.txt (buildroot 2014.02)
"...
whether your toolchain supports C\+\+ or not and whether it has
..."
I posted a patch to remove this backslash (C\+\+ --> C\++), but in the
meantime after
my discussion with Thomas P. (I suppose Thomas misunderstood me) he made
commit 082dec8ce440236b1477e568f0965f05ad241adb
So:
my patch v3 = 'revert commit of Thomas' + 'my patch v2'
commit of Thomas:
commit 082dec8ce440236b1477e568f0965f05ad241adb
my patch v2:
http://lists.busybox.net/pipermail/buildroot/2014-March/093207.html
Regards,
Jerzy
>
> Regards,
> Arnout
>
>> ---
>> v3:
>> - rebase on top of the master
>> v2:
>> - remove only one backslash
>>
>> docs/manual/configure.txt | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/docs/manual/configure.txt b/docs/manual/configure.txt
>> index c1c9477..ee5e65e 100644
>> --- a/docs/manual/configure.txt
>> +++ b/docs/manual/configure.txt
>> @@ -100,7 +100,7 @@ most important ones allow to:
>> toolchain should have largefile support (i.e. support for files
>> larger than 2 GB on 32 bits systems), IPv6 support, RPC support
>> (used mainly for NFS), wide-char support, locale support (for
>> - internationalization), C\++ support or thread support. Depending on
>> + internationalization), C++ support or thread support. Depending on
>> which options you choose, the number of userspace applications and
>> libraries visible in Buildroot menus will change: many applications
>> and libraries require certain toolchain options to be enabled. Most
>> @@ -165,7 +165,7 @@ Then, you have three solutions to use an external toolchain:
>> prefix+ and +External toolchain C library+ options. Then, you have
>> to tell Buildroot what your external toolchain supports. If your
>> external toolchain uses the 'glibc' library, you only have to tell
>> - whether your toolchain supports C++ or not and whether it has
>> + whether your toolchain supports C\++ or not and whether it has
>> built-in RPC support. If your external toolchain uses the 'uClibc'
>> library, then you have to tell Buildroot if it supports largefile,
>> IPv6, RPC, wide-char, locale, program invocation, threads and
>>
>
prev parent reply other threads:[~2014-04-05 8:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-03 21:21 [Buildroot] [PATCH v3 1/1] manual/configure.txt: fix typo Jerzy Grzegorek
2014-04-04 5:59 ` Arnout Vandecappelle
2014-04-04 9:19 ` Thomas De Schampheleire
2014-04-05 8:14 ` Jerzy Grzegorek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=533FBB7C.1020409@trzebnica.net \
--to=jerzy.grzegorek@trzebnica.net \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox