From: Luca Ceresoli <luca@lucaceresoli.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] legal-info: Add site to legal info manifest
Date: Thu, 17 Apr 2014 23:47:42 +0200 [thread overview]
Message-ID: <53504BFE.2040703@lucaceresoli.net> (raw)
In-Reply-To: <1396903522-10063-1-git-send-email-clshotwe@rockwellcollins.com>
Hi Clayton,
Clayton Shotwell wrote:
> I would like to propose adding the site to the legal-info manifest
> files. This gives a little more information on where the sources came
> from without adding much overhead. Please note that is is only for
> packages where the source is not local or set with OVERRIDE_SRCDIR.
>
> This patch works for the most part. The only issue I see with it occurs
> when the SITE for a package uses one of the common url macros such as
> BR2_GNU_MIRROR. The legal info manifest ends up having an extra set of
> double quotes in the site string.
>
> Signed-off-by: Clayton Shotwell <clshotwe@rockwellcollins.com>
Thanks for the proposal.
The idea is generally good to me: it provides a useful info with a
little effort.
The project website URL would be nice as well, but that's not easily
extracted.
Of course the double-quote issue with some packages needs to be fixed.
But this is just "implementation details". Note that, besides packages
from GNU_MIRROR it also affects the kernel from kernel.org, probably
U-Boot and Busybox, maybe a few others.
Instead, the case of packages downloaded from custom locations deserves
a little more thought on what we want to do.
When using e.g. BR2_LINUX_KERNEL_CUSTOM_GIT=y, the REPO_URL may point
either to a public server (github, gitorious, silicon vendors...) or to
an enterprise server. In the former case the repository URL is
informative. In the latter case it is not, and some companies may not
like exposing their server names to the public. You know how netadmins
are made... :)
So I'm not sure of what is the best policy when using custom (non-wget)
download methods.
--
Luca
next prev parent reply other threads:[~2014-04-17 21:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-07 20:45 [Buildroot] [PATCH] legal-info: Add site to legal info manifest Clayton Shotwell
2014-04-16 17:33 ` Thomas Petazzoni
2014-04-17 21:47 ` Luca Ceresoli [this message]
2014-04-21 15:43 ` Clayton Shotwell
2014-07-16 20:06 ` Thomas Petazzoni
2014-07-21 13:45 ` Clayton Shotwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53504BFE.2040703@lucaceresoli.net \
--to=luca@lucaceresoli.net \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox