From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnout Vandecappelle Date: Fri, 25 Apr 2014 00:45:42 +0200 Subject: [Buildroot] [PATCH 09/14] pkg-cmake.mk: globally disable BUILD_TESTING flag In-Reply-To: <1398293313-17580-10-git-send-email-s.martin49@gmail.com> References: <1398293313-17580-1-git-send-email-s.martin49@gmail.com> <1398293313-17580-10-git-send-email-s.martin49@gmail.com> Message-ID: <53599416.8090604@mind.be> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net On 24/04/14 00:48, Samuel Martin wrote: > This CMake flag is used to enable tests. It may not disable the test > programs from being built, but it controls the test execution. > > Since we don't care about building the tests (and usually disable them > when possible), make sure Buildroot won't try to run them. > > Signed-off-by: Samuel Martin > > --- > changes v1 -> v2: > - new patch > --- > package/pkg-cmake.mk | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/package/pkg-cmake.mk b/package/pkg-cmake.mk > index d6dadbe..e0efccb 100644 > --- a/package/pkg-cmake.mk > +++ b/package/pkg-cmake.mk > @@ -65,6 +65,7 @@ define $(2)_CONFIGURE_CMDS > -DCMAKE_TOOLCHAIN_FILE="$$(HOST_DIR)/usr/share/buildroot/toolchainfile.cmake" \ > -DCMAKE_INSTALL_PREFIX="/usr" \ > -DCMAKE_COLOR_MAKEFILE=OFF \ > + -DBUILD_TESTING=OFF \ Shouldn't this be done for the host variant as well? > -DBUILD_SHARED_LIBS=$(if $(BR2_PREFER_STATIC_LIB),OFF,ON) \ Not really related to this patch, but is there a specific reason why some options are set in the toolchainfile.cmake and some are set on the command line? Regards, Arnout > -DUSE_CCACHE=$(if $(BR2_CCACHE),ON,OFF) \ > $$($$(PKG)_CONF_OPT) \ > -- Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F