Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Gustavo Zacarias <gustavo@zacarias.com.ar>
To: buildroot@busybox.net
Subject: [Buildroot] Enabling readline support in wpa_cli
Date: Mon, 12 May 2014 12:44:16 -0300	[thread overview]
Message-ID: <5370EC50.7020809@zacarias.com.ar> (raw)
In-Reply-To: <c0fce23a65a14e6cbd228a9ec03cf091@DB3PR04MB075.eurprd04.prod.outlook.com>

On 05/12/2014 11:16 AM, Oscar Hellstr?m wrote:

> I should probably have added the readline dependency as well, right?

Hi.
You mean adding a Config.in select? That's not necessary, we usually
handle these "details" automatically like you've already did in your
patch, otherwise it's (possibly) just making the target size bigger for
an option that wouldn't be used.
Could you resend your last patch (based on current git) with
git-send-email and a SoB line for proper attribution?
Thanks.

  reply	other threads:[~2014-05-12 15:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-12 13:55 [Buildroot] Enabling readline support in wpa_cli Oscar Hellström
2014-05-12 14:16 ` Oscar Hellström
2014-05-12 15:44   ` Gustavo Zacarias [this message]
2014-05-12 16:12   ` Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5370EC50.7020809@zacarias.com.ar \
    --to=gustavo@zacarias.com.ar \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox