From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vicente Olivert Riera Date: Thu, 22 May 2014 11:47:31 +0100 Subject: [Buildroot] [PATCH] libnss: Enable for MIPS64 n32 platforms In-Reply-To: <20140522124602.0df63a66@free-electrons.com> References: <1400752943-49138-1-git-send-email-Vincent.Riera@imgtec.com> <20140522121054.6898c229@free-electrons.com> <537DCD68.4050309@imgtec.com> <20140522124602.0df63a66@free-electrons.com> Message-ID: <537DD5C3.8010903@imgtec.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net On 05/22/2014 11:46 AM, Thomas Petazzoni wrote: > Dear Vicente Olivert Riera, > > On Thu, 22 May 2014 11:11:52 +0100, Vicente Olivert Riera wrote: > >>>> -ifeq ($(BR2_ARCH_IS_64),y) >>>> +ifeq ($(BR2_ARCH_IS_64)$(BR2_MIPS_NABI32),yn) >>> >>> This cannot work: when an option is disabled, its value is empty, not >>> 'n'. >>> >>> So: >>> >>> # a comment here that explains the exception for MIPS_NABI32 >>> ifeq ($(BR2_ARCH_IS_64),y) >>> ifeq ($(BR2_MIPS_NABI32),) >>> ... >>> endif >>> endif >>> >>> Thanks! >>> >>> Thomas >>> >> >> I tried it and it worked. > > Yes, it worked in your case, because the condition had to be false in > your case. But with your implementation, the condition will *always* be > false, so the USE_64 thing will no longer be passed for BR2_ARCH_IS_64 > situations that are *not* BR2_MIPS_NABI32. > > Thomsa > Ok, understood. The v2 patch was already sent and it has all the changes you and Baruch suggested. -- Vincent