From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnout Vandecappelle Date: Wed, 28 May 2014 12:30:06 +0200 Subject: [Buildroot] [PATCH v2] Adding support for Ariag25 and Terra board from Acmesystems In-Reply-To: References: <1400875790-20928-1-git-send-email-angelo.compagnucci@gmail.com> <5385811C.6090700@mind.be> Message-ID: <5385BAAE.3020207@mind.be> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net On 28/05/14 11:41, Angelo Compagnucci wrote: >>> +CONFIG_SOC_AT91SAM9260=y >>> +CONFIG_SOC_AT91SAM9261=y >>> +CONFIG_SOC_AT91SAM9263=y >>> +CONFIG_SOC_AT91SAM9RL=y >>> +CONFIG_SOC_AT91SAM9G45=y >>> +CONFIG_SOC_AT91SAM9X5=y >>> +CONFIG_SOC_AT91SAM9N12=y >> >> Any reason to support all these different chips? > > I used the kernel config provided by Acmesystems, do you think it > should be reviewed? No, just mention in the README or in the commit message where it comes from then. > >>> +CONFIG_MACH_AT91SAM9_DT=y >>> +CONFIG_AT91_TIMER_HZ=128 >>> +CONFIG_AEABI=y >> [snip] >>> +CONFIG_EXT4_FS=y >>> +CONFIG_EXT4_FS_POSIX_ACL=y >> >> Why do you need ext4 support? > > Why not? EXT4 is ubiquitous and used extensively on AriaG25 / Terra board. The config you provide doesn't show that because it doesn't have an ext4 rootfs. > >>> diff --git a/board/acmesystems/ariag25_terra/fs-overlay/etc/network/interfaces b/board/acmesystems/ariag25_terra/fs-overlay/etc/network/interfaces >>> new file mode 100644 >>> index 0000000..104c1a1 >>> --- /dev/null >>> +++ b/board/acmesystems/ariag25_terra/fs-overlay/etc/network/interfaces >> >> You're not actually using this in your defconfigs... > > Ouch, big mistake, sorry. > >>> +BR2_TOOLCHAIN_BUILDROOT_LARGEFILE=y >> >> There's no reason to have this in the minimal defconfig. > > Ok, I'll remove it > >>> +BR2_TARGET_GENERIC_HOSTNAME="ariag25" >>> +BR2_TARGET_GENERIC_ISSUE="Welcome to AriaG25 by www.acmesystems.it!" >>> +BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_MDEV=y >>> +BR2_LINUX_KERNEL=y >>> +BR2_LINUX_KERNEL_USE_CUSTOM_CONFIG=y >>> +BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE="board/acmesystems/ariag25/at91-ariag25.config" >>> +BR2_LINUX_KERNEL_DTS_SUPPORT=y >>> +BR2_LINUX_KERNEL_USE_CUSTOM_DTS=y >>> +BR2_LINUX_KERNEL_CUSTOM_DTS_PATH="board/acmesystems/ariag25/at91-ariag25.dts" >> >> Since you create just a root filesystem and a kernel, not even a bootloader, >> I'd expect a README file with an explanation how you get this stuff on your device. > > Ok, I will add the at91 bootloader. And a readme about how to put it on the board. You can make it very short and just refer to a website - on condition that the instructions on that website are correct for the images generated by buildroot. We want a user to be able to boot a board with buildroot by doing: - make ariag25_defconfig - follow the instructions in board/acmesystems/ariag25/readme.txt > >>> +BR2_PACKAGE_PYTHON=y >>> +BR2_PACKAGE_PYTHON_SQLITE=y >>> +BR2_PACKAGE_PYTHON_ZLIB=y >>> +BR2_PACKAGE_PYTHON_SERIAL=y >>> +BR2_PACKAGE_DROPBEAR=y >>> +BR2_PACKAGE_IPUTILS=y >>> +BR2_PACKAGE_NTP=y >>> +BR2_PACKAGE_OPKG=y >> >> I like the fact that we get our first demo config. However, I don't understand >> the choice of packages here. dropbear makes a lot of sense of course, but the >> others just seem a bit random. In this case, I don't think the demo config makes >> a lot of sense. > > It should be a rationale for a demo board? I choose that packages > because the provides a minimal support to run the examples provided on > the manufacturer's website. That's perfect - but then you should refer to the examples on the website, and how to install them on the system. Perhaps even create a package for them (though that's probably not very useful). > Why do you think they are randomly chosen? > Python packages are useful for running website examples, OK > iputils > contains basic useful commands as ping, ntp is ntp, Those are also in busybox. > and OPKG makes > possible to add other pre-compiled software from > http://feeds.angstrom-distribution.org/ Have you tried that? I doubt that angstrom uses uClibc toolchains... Regards, Arnout > > I don't think it' so random :) ! > > Sincerly, > > Angelo > -- Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F