From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnout Vandecappelle Date: Mon, 16 Jun 2014 07:35:40 +0200 Subject: [Buildroot] [git commit] hdparm: prevent package makefile from stripping the hdparm binary In-Reply-To: <20140611210500.36A4A9CFCA@busybox.osuosl.org> References: <20140611210500.36A4A9CFCA@busybox.osuosl.org> Message-ID: <539E822C.5040708@mind.be> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net On 06/11/14 23:03, Peter Korsgaard wrote: > commit: http://git.buildroot.net/buildroot/commit/?id=11dbb615338cd768acc2c3138064ddf557e9b60b > branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master > > Packages shouldn't strip executables by themselves, so that Buildroot > controls whether stripping should occur or not. This also fixes the > build on Blackfin FLAT where stripping actually doesn't work because > stripping FLAT binaries is not supported. > > Fixes: > > http://autobuild.buildroot.org/results/7d4/7d4e59c96928a06db5091235bf2eacf462ba8a21/ > > Signed-off-by: Thomas Petazzoni > Reviewed-by: "Yann E. MORIN" > Signed-off-by: Peter Korsgaard > --- > package/hdparm/hdparm.mk | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/package/hdparm/hdparm.mk b/package/hdparm/hdparm.mk > index 1a200fb..0ca3c39 100644 > --- a/package/hdparm/hdparm.mk > +++ b/package/hdparm/hdparm.mk > @@ -12,7 +12,8 @@ HDPARM_LICENSE_FILES = LICENSE.TXT > define HDPARM_BUILD_CMDS > $(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D) \ > CFLAGS="$(TARGET_CFLAGS)" \ > - LDFLAGS="$(TARGET_LDFLAGS)" > + LDFLAGS="$(TARGET_LDFLAGS)" \ > + STRIP=/bin/true Perhaps for consistency we should rename $(TARGET_CROSS)strip to $(TARGET_CROSS)real-strip and symlink $(TARGET_CROSS)strip to /bin/true? While looking at this, I also notice that in some cases we _do_ pass the real strip, e.g. in fltk, qt (but not qt5). I guess that's historical accident? Regards, Arnout > endef > > define HDPARM_INSTALL_TARGET_CMDS > _______________________________________________ > buildroot mailing list > buildroot at busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot > > -- Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F