From: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] dbus: use -pthread instead of -lpthread
Date: Mon, 30 Jun 2014 17:54:27 +0100 [thread overview]
Message-ID: <53B19643.1010904@imgtec.com> (raw)
In-Reply-To: <20140630164911.GI4425@tarshish>
On 06/30/2014 05:49 PM, Baruch Siach wrote:
> Hi Vicente,
>
> On Mon, Jun 30, 2014 at 05:28:12PM +0100, Vicente Olivert Riera wrote:
>> This fixes a problem in other packages when they link against dbus. For
>> instance, with the dnsmasq package:
>>
>> /buildroot/output/host/usr/bin/mipsel-ctng-linux-uclibc-gcc --static
>> -lidn -o dnsmasq cache.o rfc1035.o util.o option.o forward.o network.o
>> dnsmasq.o dhcp.o lease.o rfc2131.o netlink.o dbus.o bpf.o helper.o
>> tftp.o log.o conntrack.o dhcp6.o rfc3315.o dhcp-common.o outpacket.o
>> radv.o slaac.o auth.o ipset.o domain.o dnssec.o blockdata.o
>> -L/buildroot/output/host/usr/mipsel-buildroot-linux-uclibc/sysroot/usr/lib
>> -ldbus-1 -lpthread
>> -L/buildroot/output/host/usr/mipsel-buildroot-linux-uclibc/sysroot/usr/lib
>> -lidn -liconv
>> -L/buildroot/output/host/usr/mipsel-buildroot-linux-uclibc/sysroot/usr/lib
>> -llua -lm -Wl,-Bstatic -lhogweed
>> -L/buildroot/output/host/usr/mipsel-buildroot-linux-uclibc/sysroot/usr/lib
>> -lnettle -lgmp -Wl,-Bdynamic -Wl,-Bstatic -lgmp -Wl,-Bdynamic
>> /buildroot/output/host/usr/mipsel-buildroot-linux-uclibc/sysroot/usr/lib/libpthread.a(init.os):
>> In function `__pthread_initialize_minimal_internal':
>> init.c:(.text+0x26c): undefined reference to `__libc_setup_tls'
>> collect2: error: ld returned 1 exit status
>> make[2]: *** [dnsmasq] Error 1
>> make[2]: Leaving directory
>> `/buildroot/output/build/dnsmasq-2.71/src'
>>
>> Fixes:
>> http://autobuild.buildroot.net/results/7cd/7cdab3b6f74dbfde965300a51e58a377ba30602b/
>>
>> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
>> ---
>> package/dbus/dbus.mk | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/package/dbus/dbus.mk b/package/dbus/dbus.mk
>> index fc446b1..0c8fcf3 100644
>> --- a/package/dbus/dbus.mk
>> +++ b/package/dbus/dbus.mk
>> @@ -35,7 +35,7 @@ define DBUS_USERS
>> endef
>>
>> ifeq ($(BR2_PREFER_STATIC_LIB),y)
>> -DBUS_CONF_OPT += LIBS='-lpthread'
>> +DBUS_CONF_OPT += LIBS='-pthread'
>
> Can you explain how this change solves the build failure?
Yes. When dnsmasq tries to link against dbus it checks the dbus
pkgconfig file to obtain the LIBS that it need to pass to the linker. In
the dbus .pc file you have "-ldbus-1 -lpthread" because you used
-lpthread when building dbus. If you use -pthread when you build dbus,
then you will have -pthread in the dbus .pc file as well.
> baruch
>
>> endif
>>
>> ifeq ($(BR2_microblaze),y)
>
--
Vincent
next prev parent reply other threads:[~2014-06-30 16:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-30 16:28 [Buildroot] [PATCH] dbus: use -pthread instead of -lpthread Vicente Olivert Riera
2014-06-30 16:49 ` Baruch Siach
2014-06-30 16:54 ` Vicente Olivert Riera [this message]
2014-06-30 18:06 ` Thomas Petazzoni
2014-06-30 18:46 ` Baruch Siach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B19643.1010904@imgtec.com \
--to=vincent.riera@imgtec.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox