[Buildroot] [PATCH 0/3] Make exim more configurable

[Luca Ceresoli <luca@lucaceresoli.net>]

Dear Thomas,

Thomas Petazzoni wrote:
> Dear Luca Ceresoli,
>
> On Wed, 16 Jul 2014 10:50:30 +0200, Luca Ceresoli wrote:
>
>> How do the autobuilders handle the same situation for the Linux or
>> Barebox custom configuration files? E.g.:
>>
>>     # BR2_LINUX_KERNEL_USE_DEFCONFIG is not set
>>     BR2_LINUX_KERNEL_USE_CUSTOM_CONFIG=y
>>     BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE=""
>>
>> This would fail in the same way. Obvious enough, since for exim I just
>> copied the same checks...
>>
>> Do the autobuilders have a special handling for the kernel and
>> bootloaders? If that's the case, of course it would not be viable to do
>> it for each and every package.
>
> Since the Linux kernel and bootloader options do not start with
> BR2_PACKAGE_* they are not part of the randpackageconfig randomization,
> and therefore the autobuilders never build the Linux kernel or the
> bootloaders.
>
> We however have a similar situation with other packages, in which case
> the autobuilder script comes to help, see for example
> http://git.buildroot.net/buildroot-test/tree/scripts/autobuild-run#n244.
>
>>> Options:
>>>
>>>    1/ Have a default value for BR2_PACKAGE_EXIM_CUSTOM_CONFIG_FILE that
>>>       actually works.
>>
>> That would be quite simple. Enough to run a build with
>> BR2_PACKAGE_EXIM_CUSTOM_CONFIG disabled, pick the config file from
>> the build dir, remove the toolchain additions and put the file in
>> packace/exim/default-config.
>
> That is one solution.
>
>> I agree options 2 and 3 would be more annoying.
>
> They are possible, we do this for other packages already.
>
>> Another option is:
>>
>>     4/ Remove BR2_PACKAGE_EXIM_CUSTOM_CONFIG knob and make exim use the
>>        custom configuration only if
>>        BR2_PACKAGE_EXIM_CUSTOM_CONFIG_FILE != "". I assume the
>>        autobuilders never set BR2_PACKAGE_EXIM_CUSTOM_CONFIG_FILE, do
>>        they?
>
> Indeed, randpackageconfig only takes care of boolean or tristate
> options, so BR2_PACKAGE_EXIM_CUSTOM_CONFIG_FILE would remain empty in
> terms of autobuilder testing.

I'm ok with all options except option 2 which seems the most complex:
both add a config file and modify the autobuilders.

However I slightly prefer option 4, which is the one involving less
code. Indeed it removes lines!

So I just sent a patch doing that:
   http://patchwork.ozlabs.org/patch/370792/

If discussion leads to another choice, I'll cook another patch.

-- 
Luca