Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Hadrien Boutteville <hadrien.boutteville@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] ti-gfx: add patch to fix build failure with es5.x
Date: Fri, 18 Jul 2014 18:46:04 +0200	[thread overview]
Message-ID: <53C94F4C.6070500@gmail.com> (raw)
In-Reply-To: <20140715180419.0ad269fd@free-electrons.com>

Hello Thomas,

On Tue, 15 Jul 2014 18:04:19 +0200, Thomas Petazzoni wrote:
> Dear Hadrien Boutteville,
> 
> On Tue, 15 Jul 2014 17:54:15 +0200, Hadrien Boutteville wrote:
> 
>> +--- a/GFX_Linux_KM/services4/3rdparty/dc_omapfb3_linux/omaplfb_linux.c
>> ++++ b/GFX_Linux_KM/services4/3rdparty/dc_omapfb3_linux/omaplfb_linux.c
>> +@@ -177,7 +177,7 @@
>> + #if (LINUX_VERSION_CODE < KERNEL_VERSION(3,7,0))
>> + #define OMAP_DSS_MANAGER(man, dev) struct omap_overlay_manager *man = (dev) != NULL ? (dev)->manager : NULL
>> + #else
>> +-#define OMAP_DSS_MANAGER(man, dev) struct omap_overlay_manager *man = (dev) != NULL ? (dev)->output->manager : NULL
>> ++#define OMAP_DSS_MANAGER(man, dev) struct omap_overlay_manager *man = (dev) != NULL ? (dev)->src->manager : NULL
> 
> Isn't this going to break with some kernel versions? I believe an
> additional condition on LINUX_VERSION_CODE might be needed, no?

Indeed, I'm sending a new version.

Thanks,

Hadrien

      reply	other threads:[~2014-07-18 16:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-15 15:54 [Buildroot] [PATCH 1/1] ti-gfx: add patch to fix build failure with es5.x Hadrien Boutteville
2014-07-15 16:04 ` Thomas Petazzoni
2014-07-18 16:46   ` Hadrien Boutteville [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53C94F4C.6070500@gmail.com \
    --to=hadrien.boutteville@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox