Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Floris Bos <bos@je-eigen-domein.nl>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] odhcploc: new package
Date: Sun, 17 Aug 2014 22:51:14 +0200	[thread overview]
Message-ID: <53F115C2.4060907@je-eigen-domein.nl> (raw)
In-Reply-To: <20140817213415.5ea4809a@free-electrons.com>

On 08/17/2014 09:34 PM, Thomas Petazzoni wrote:
> On Sat,  9 Aug 2014 20:06:57 +0200, Floris Bos wrote:
>> Adds odhcploc, a network utility to scan for (rogue) DHCP servers.
>>
>> Signed-off-by: Floris Bos <bos@je-eigen-domein.nl>
> Thanks, I've applied the patch to the next branch, after doing a few
> changes, see below.

Thanks for applying.


> +define ODHCPLOC_BUILD_CMDS
> +     $(MAKE) CC="$(TARGET_CC)" LD="$(TARGET_LD)" -C $(@D) all
> Used tab for indentation instead of spaces, and replaced CC=.. LD=.. by
> $(TARGET_CONFIGURE_OPTS).

Fine with me.
Had copied the CC=.. LD=.. construct from the manual though ( 
http://www.buildroot.org/downloads/manual/manual.html#_infrastructure_for_packages_with_specific_build_systems 
)
Perhaps mention $(TARGET_CONFIGURE_OPTS) there as well?

-- 
Yours sincerely,

Floris Bos

  reply	other threads:[~2014-08-17 20:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-09 18:06 [Buildroot] [PATCH 1/1] odhcploc: new package Floris Bos
2014-08-10  7:03 ` Thomas De Schampheleire
2014-08-17 19:34 ` Thomas Petazzoni
2014-08-17 20:51   ` Floris Bos [this message]
2014-08-18  7:46     ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53F115C2.4060907@je-eigen-domein.nl \
    --to=bos@je-eigen-domein.nl \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox