Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Nathaniel Roach <nroach44@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4] bandwidthd: Version bump to fix autobuilder errors
Date: Thu, 21 Aug 2014 18:42:45 +0800	[thread overview]
Message-ID: <53F5CD25.2030300@gmail.com> (raw)
In-Reply-To: <20140821103421.GG2405@tarshish>

On 21/08/14 18:34, Baruch Siach wrote:
> Hi Nathaniel,
> 
> On Thu, Aug 21, 2014 at 06:24:55PM +0800, Nathaniel Roach wrote:
>> Thanks to Romain Naour, we've found that certain tests
>> in configure fail if their dependencies aren't tested for
>> beforehand.
>>  	depends on BR2_USE_MMU # fork()
>> +	select BR2_PACKAGE_ZLIB
> 
> Is bandwidthd using libz directly? If not, libpng already selects 
> BR2_PACKAGE_ZLIB so this may not actually be needed?

You are correct, it's only through libpng that zlib is used. I put it in
there as a safeguard because bandwidthd's configure script does test for
it's existence, as the libpng tests can fail without first testing for zlib.

The above issue should be covered by libpng anyway. I don't see any harm
in it being there, but if you think it should be removed I'll undo the
changes.

> 
>> -BANDWIDTHD_DEPENDENCIES = gd libpng libpcap
>> +BANDWIDTHD_DEPENDENCIES = gd libpng libpcap zlib
> 
> Same here.
> 
> baruch
> 
>>  
>>  BANDWIDTHD_AUTORECONF = YES
>>  
>> -BANDWIDTHD_CONF_OPT += --without-x
>> -
>>  ifeq ($(BR2_PACKAGE_BANDWIDTHD_POSTGRESQL),y)
>>  BANDWIDTHD_DEPENDENCIES += postgresql
>>  BANDWIDTHD_CONF_OPT += --with-postgresql-logging=true
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20140821/e613a9cf/attachment.asc>

  reply	other threads:[~2014-08-21 10:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-21 10:24 [Buildroot] [PATCH v4] bandwidthd: Version bump to fix autobuilder errors Nathaniel Roach
2014-08-21 10:34 ` Baruch Siach
2014-08-21 10:42   ` Nathaniel Roach [this message]
2014-08-21 10:55     ` Baruch Siach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53F5CD25.2030300@gmail.com \
    --to=nroach44@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox