From: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] package/procps-ng: fix linking with intl
Date: Thu, 21 Aug 2014 15:21:10 +0100 [thread overview]
Message-ID: <53F60056.7070504@imgtec.com> (raw)
In-Reply-To: <1408629367-7336-2-git-send-email-romain.naour@openwide.fr>
On 08/21/2014 02:56 PM, Romain Naour wrote:
> procps-ng doesn't build with (e)glibc toolchain when gettext package is
> selected.
>
> With (e)glibc libintl is provided by the libc whereas with uClibc it's provided
> by gettext.
>
> Linking with intl is only needed if the toolchain needs gettext and locale is
> set.
>
> Fixes:
> http://autobuild.buildroot.net/results/3e8/3e8464e0b00ce22fa02a6337159fca250d86425c/build-end.log
>
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
> ---
> package/procps-ng/procps-ng.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/procps-ng/procps-ng.mk b/package/procps-ng/procps-ng.mk
> index 7628c21..8f9caf3 100644
> --- a/package/procps-ng/procps-ng.mk
> +++ b/package/procps-ng/procps-ng.mk
> @@ -12,7 +12,7 @@ PROCPS_NG_LICENSE_FILES = COPYING COPYING.LIB
>
> PROCPS_NG_DEPENDENCIES = ncurses
>
> -ifeq ($(BR2_PACKAGE_GETTEXT),y)
> +ifeq ($(BR2_NEEDS_GETTEXT_IF_LOCALE),y)
> PROCPS_NG_DEPENDENCIES += gettext
> PROCPS_NG_CONF_OPT += LIBS=-lintl
> endif
>
Tested-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
--
Vincent
next prev parent reply other threads:[~2014-08-21 14:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-21 13:56 [Buildroot] [PATCH 1/2] package/xscreensaver: fix linking with intl Romain Naour
2014-08-21 13:56 ` [Buildroot] [PATCH 2/2] package/procps-ng: " Romain Naour
2014-08-21 14:21 ` Vicente Olivert Riera [this message]
2014-08-25 17:55 ` Thomas Petazzoni
2014-08-25 18:01 ` [Buildroot] [PATCH 1/2] package/xscreensaver: " Thomas Petazzoni
2014-08-25 21:00 ` Romain Naour
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53F60056.7070504@imgtec.com \
--to=vincent.riera@imgtec.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox