From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 00/12] toolchain: warn for unsafe library/header paths
Date: Tue, 26 Aug 2014 22:14:06 +0200 [thread overview]
Message-ID: <53FCEA8E.3030600@mind.be> (raw)
In-Reply-To: <20140824112218.GA3778@free.fr>
[/me is back from too long holidays, facing 2000 BR mails :-)]
On 08/24/14 13:22, Yann E. MORIN wrote:
> Thomas?, All,
>
> On 2014-08-22 21:29 +0200, Thomas De Schampheleire spake thusly:
>> "Yann E. MORIN" <yann.morin.1998@free.fr> schreef:
>>> Thomas, All,
>>>
>>> On 2014-08-21 23:33 +0200, Thomas Petazzoni spake thusly:
>>>> On Thu, 21 Aug 2014 22:30:29 +0200, Romain Naour wrote:
>>>>> Also, BR_COMPILER_PARANOID_UNSAFE_PATH needs to be renamed to
>>>>> BR2_COMPILER_PARANOID_UNSAFE_PATH to follow the naming scheme ?
>>>>
>>>> No: BR2_* variables are Config.in options. Environment variables are
>>>> BR_*.
>>>
>>> Earlier this year in Brussels, we said we were to use BR2_ everywhere :
>>> http://elinux.org/Buildroot:DeveloperDaysFOSDEM2014
>>
>> Hmm, that is written in the conclusion, but this is very
>> different than what is in the 'proposed rules'.
>> Was it really the final outcome to use BR2 for all types
>> of variable? I thought we wanted to make a
>> distinction between config variables and others...
>
> Yes, I was a bit surprised by the conclusion, too.
> From what I remember, I thought we decided for:
> - user-facing variables: prefix with BR2_
> - internal variables: prefix with BR_
>
> IIRC, we already have a few changesets implementing those rules.
>
> For example:
> 35c666e toolchain/wrapper: rename BR_DEBUG_WRAPPER
>
> (I could not find another reverse such change, unfortunetely...)
Blame the reporter.
The conclusion was:
* BR2_ for all Kconfig variables;
* BR2_ for user-facing environment variables;
* BR_ for internal environment variables.
Other such changes:
4113b3c infra: replace BUILDROOT_CONFIG with BR2_CONFIG
6768021 infra: replace BUILDROOT_DL_DIR with BR2_DL_DIR.
Regards,
Arnout
>
> Regards,
> Yann E. MORIN.
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
prev parent reply other threads:[~2014-08-26 20:14 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-20 13:06 [Buildroot] [PATCH 00/12] toolchain: warn for unsafe library/header paths Thomas Petazzoni
2014-08-20 13:06 ` [Buildroot] [PATCH 01/12] toolchain-external: instrument wrapper to warn about unsafe paths Thomas Petazzoni
2014-09-10 19:42 ` Yann E. MORIN
2014-09-10 20:18 ` Thomas Petazzoni
2014-09-10 20:23 ` Yann E. MORIN
2014-08-20 13:06 ` [Buildroot] [PATCH 02/12] binutils/2.24: add patch to warn about unsafe library paths Thomas Petazzoni
2014-09-10 19:52 ` Yann E. MORIN
2014-09-10 20:19 ` Thomas Petazzoni
2014-08-20 13:06 ` [Buildroot] [PATCH 03/12] binutils/2.23: " Thomas Petazzoni
2014-08-20 13:06 ` [Buildroot] [PATCH 04/12] binutils/2.22: " Thomas Petazzoni
2014-08-20 13:06 ` [Buildroot] [PATCH 05/12] binutils/arc-4.8-R3: " Thomas Petazzoni
2014-08-20 13:06 ` [Buildroot] [PATCH 06/12] gcc/4.9: add patch to warn about unsafe header paths Thomas Petazzoni
2014-09-10 20:08 ` Yann E. MORIN
2014-09-10 20:24 ` Thomas Petazzoni
2014-09-10 22:10 ` Yann E. MORIN
2014-08-20 13:06 ` [Buildroot] [PATCH 07/12] gcc/4.8: " Thomas Petazzoni
2014-08-20 13:06 ` [Buildroot] [PATCH 08/12] gcc/arc-4.8-R3: " Thomas Petazzoni
2014-08-20 13:06 ` [Buildroot] [PATCH 09/12] gcc/4.7: " Thomas Petazzoni
2014-08-20 13:06 ` [Buildroot] [PATCH 10/12] gcc: enable poison system directories option Thomas Petazzoni
2014-09-10 20:09 ` Yann E. MORIN
2014-08-20 13:06 ` [Buildroot] [PATCH 11/12] binutils: " Thomas Petazzoni
2014-09-10 20:09 ` Yann E. MORIN
2014-08-20 13:06 ` [Buildroot] [PATCH 12/12] Add option for paranoid unsafe path checking Thomas Petazzoni
2014-09-10 20:12 ` Yann E. MORIN
2014-08-21 20:30 ` [Buildroot] [PATCH 00/12] toolchain: warn for unsafe library/header paths Romain Naour
2014-08-21 21:33 ` Thomas Petazzoni
2014-08-22 16:30 ` Yann E. MORIN
2014-08-22 19:29 ` Thomas De Schampheleire
2014-08-24 11:22 ` Yann E. MORIN
2014-08-26 20:14 ` Arnout Vandecappelle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53FCEA8E.3030600@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox